While looking at the export of this data I realized there's something weird going on. It generates entries similar to:
{
"gitterUserId": "1234",
"mxid": "@foo_twitter-1234:gitter.im",
"provider": "github",
"providerKey": "undefined"
}I see two oddities with this:
twitter in it, but the provider is GitHub. (There are also ones for gitlab.)providerKey is "undefined", which shouldn't be possible.From discussion with @MadLittleMods this could be related to #2328 (closed).
Patrick Cloke (9ed87c31) at 28 Dec 18:30
See !2319 (merged) for a fix to this.
Follow-up to !2318
Without this change the file periodically ends up with two entries on the same line, making the file much harder to parse.
Example of the broken file:
{"gitterUserId":"abcdef","mxid":"@alice-abcdef:gitter.im","provider":"github","providerKey":"1234"}
{"gitterUserId":"ghijkl","mxid":"@bob-ghijkl:gitter.im","provider":"github","providerKey":"5678"}{"gitterUserId":"mnopqr","mxid":"@charlie-mnopqr:gitter.im","provider":"github","providerKey":"9123"}This change should fix the broken lines (although I have no way to test it), I believe this now conforms to ndjson.
Related to #2856.
Patrick Cloke (9ed87c31) at 28 Dec 16:11
Ensure there's a trailing newline on each user identity info entry.
Patrick Cloke (0575f9f7) at 28 Dec 16:10
Ensure there's a trailing newline on each user identity info entry.
Patrick Cloke (f6c75d2e) at 28 Dec 16:09
This creates broken data when appending to an existing file -- there's no final \n on ndJsonString so the first entry on the second call gets put on the same line as the last entry.
Patrick Cloke (99cd8a9c) at 24 Oct 13:37
Add support for Sentry.
Patrick Cloke (ffccc6e3) at 23 Aug 23:30
Update changelog.
Patrick Cloke (7df444be) at 23 Aug 16:10
Patrick Cloke (37e139a6) at 23 Aug 14:58