@kushalpandya Can you review my MR please?

Before, the URL param was type[]=EPIC. Now, we are using gids but only the numerical value for the URLs, so now the URL param is type[]=2 (or whichever value it is for epic)

The wildcard value is already handled by default, so the camelCase transformation was moved into the formatData function above which deals with transforming the value

The data for the subscribed token is already uppercase, so since we don't need to do any transformation then we can remove this

The Type token values are no longer enums so we no longer need to uppercase them

Before, we were sending the backend an enum (e.g. ISSUE, INCIDENT). Now, we are sending the backend a gid (e.g. gid://gitlab/WorkItems::Type/1)

What does this MR do and why?

Update work item lists to filter by type using gids (#592521)

Previously, we filtered by type using an enum (ISSUE, INCIDENT, etc). With CWITs, we cannot rely on names anymore as users can rename and create new types. Now, we are filtering by type using gids.

Changelog: changed

References

• #592521

Screenshots or screen recordings

How to set up and validate locally

1. Go to the work items list or the epics list
2. Confirm the type token still works as expected

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #592521

Coung Ngo (92085dc9) at 17 Mar 17:06

@harsh.codes The length has changed because we are no longer filtering in the frontend anymore. We've removed the filtering on the frontend because we now expect the backend response to return filtered results, so we are now just rendering all supportedConversionTypes. There are 5 elements in supportedConversionTypes, plus the "Select type" option we add, which equals the expected 6

@narendran-kannan Can you do test review of my MR please?

@bwilkerson13 Can you do QA review of my MR please?

@harsh.codes I might have accidentally removed it when refactoring the test. I've added it back in 👍

Coung Ngo (1875ab0a) at 17 Mar 11:13

This might possibly be caused by the frontend still using NAME_TO_TEXT_MAP for rendering the CWIT names on the UI. We are removing it in !226585, so once that's merged I'll see if that fixes this issue

Coung Ngo (20c4fda9) at 17 Mar 10:41

Thanks @rliu-gl, frontend LGTM! There's some additional frontend code we can delete but we can do that in a separate MR if you prefer

Relates to https://gitlab.com/gitlab-org/gitlab/-/work_items/593618

Summary

This MR removes the enable_free_purchase_dap_monthly_commit feature flag, it has been rolled out to 100% in production since March 12th: https://gitlab.com/gitlab-com/gl-infra/feature-flag-log/-/work_items/55737.

Permanently enabling the new group billing's page for free and trial namespaces. It also productizes some UX updates for Trial CTAs on GitLab Credits Page, GitLab Duo Page and End of Trial Modal.

• Initial implementation for new billings page: https://gitlab.com/gitlab-org/gitlab/-/work_items/591000
• UX updates for trial CTAs: https://gitlab.com/gitlab-org/gitlab/-/work_items/591001

Unreachable code (mostly frontend) will be cleanup in follow-up MRs to keep this MR small for review.

Non-blocking (can do in separate MR): It looks like we can delete the code that mounted on this ID selector in ~/pages/groups/billings/index.js#L11 including ee/groups/billing/components/app.vue etc

Coung Ngo (89c3b7f7) at 16 Mar 21:20

@harsh.codes Yes that's okay 👍

What does this MR do and why?

Shows custom Work Item types within Custom Fields config form.

References

• gitlab-org#19883

Screenshots or screen recordings

How to set up and validate locally

1. Enable work_item_configurable_types globally on GDK (if !227336 is merged, you can enable it only for specific group).
2. Go to that group's > Settings > Work Items
3. Within Work Item types, add a new custom type
4. On the same page below within Custom Fields, add/edit a custom field
5. Notice in the types dropdown to have your newly created type also listed

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #591415