I want to be clear that having a little friction for reviewing isn't a bad thing. But it feels like the friction is in the wrong location. As it is, I can approve an MR without ever leaving the overview tab with a single click (not even looking at the changes I'm approving). But I do not have a quick way to approve an MR after reviewing the changes.
It's usable, just as today's UI is usable. My workflow involves going to the "changes" tab and scrolling down through all the changes, leaving comments as necessary. If it looks good I want to approve upon reaching the bottom. I would hope my next action is a single click on an "approve" at the bottom of the changes tab.
Currently as a required codeowner I do NOT see the "your review" button until I have left a comment and clicked "start review", which I may not do while approving a small merge request. So this leaves me two paths to review an MR once I have reviewed the changes.
Ideally I would have a single approve button at the bottom of the changes tab. Alternatively, allowing the review from the changes tab without having to leave a line level comment would be nice.
Will this redesign move (or additionally add) the approve button to the changes tab (ideally accessible after having scrolled to review the code)?