Dan Ginovker activity

Dan Ginovker opened merge request !114: Fix AIO AIO not working if you start the script while logged in. at OpenRSC / IdleRSC

2024-12-13T08:17:19Z

Fix AIO AIO not working if you start the script while logged in. This happens because I never tested this flow

Dan Ginovker pushed new project branch fixaioaionotworkingwhenloggedin at Dan Ginovker / IdleRSC-2

2024-12-13T08:17:09Z

Dan Ginovker (d92ffb98) at 13 Dec 08:17

Fix AIO AIO not working if you start the script while logged in. Th...

... and 18 more commits

Dan Ginovker pushed to project branch master at Dan Ginovker / IdleRSC

2024-12-13T08:14:52Z

Dan Ginovker (0589400d) at 13 Dec 08:14

Dan Ginovker pushed to project branch master at Dan Ginovker / IdleRSC

2024-12-13T08:14:34Z

Dan Ginovker (b0089e9b) at 13 Dec 08:14

Merge branch 'master' of https://gitlab.com/idlersc/idlersc

... and 4 more commits

Dan Ginovker pushed to project branch master at Dan Ginovker / IdleRSC

2024-12-13T08:13:25Z

Dan Ginovker (0589400d) at 13 Dec 08:13

Merge branch 'SeattaBranch' into 'master'

... and 791 more commits

Dan Ginovker pushed new project branch fixaioaionotworkingwhenloggedin at Dan Ginovker / IdleRSC

2024-12-13T08:12:13Z

Dan Ginovker (d92ffb98) at 13 Dec 08:12

Fix AIO AIO not working if you start the script while logged in. Th...

... and 792 more commits

Dan Ginovker opened issue #4: Make Readme specify where the client plugin source code is at 2009Scape / Tools / client-plugins

2024-11-27T17:30:55Z

Logged into Reddit for the first time in years and saw this DM

Dan Ginovker opened issue #24: Bug causing Saradomin to not open at 2009Scape / Saradomin Launcher

2024-11-22T03:25:33Z

Someone reported in Discord

$ flatpak run org._2009scape.Launcher 
Unhandled exception. System.ArgumentException: An item with the same key has already been added. Key: UPDATEAVAILABLE
   at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
   at System.Collections.Generic.Dictionary`2.Add(TKey key, TValue value)
   at Saradomin.Infrastructure.Services.PluginDownloadService.ParseInfo(String pluginName, String text)
   at Saradomin.Infrastructure.Services.PluginDownloadService.ProcessMetadataPath(String path, String pluginRepositoryPath, Boolean isUpdateCheck, Boolean writePersistentUpdateFlag)
   at Saradomin.Infrastructure.Services.PluginDownloadService.GetAllMetadata(String pluginRepositoryPath, Boolean isUpdateCheck, Boolean writePersistentUpdateFlag)
   at Saradomin.ViewModel.Controls.PluginManagerViewModel.RefreshPluginCollections()
   at Saradomin.ViewModel.Controls.PluginManagerViewModel.MainViewLoaded(MainViewLoadedMessage _)
   at System.Threading.Tasks.Task.<>c.b__128_0(Object state)
   at Avalonia.Threading.SendOrPostCallbackDispatcherOperation.InvokeCore()
   at Avalonia.Threading.DispatcherOperation.Execute()
   at Avalonia.Threading.Dispatcher.ExecuteJob(DispatcherOperation job)
   at Avalonia.Threading.Dispatcher.ExecuteJobsCore(Boolean fromExplicitBackgroundProcessingCallback)
   at Avalonia.Threading.Dispatcher.Signaled()
   at Avalonia.X11.X11PlatformThreading.CheckSignaled()
   at Avalonia.X11.X11PlatformThreading.RunLoop(CancellationToken cancellationToken)

Apparently deleting plugin folder fixed

Dan Ginovker commented on issue #9 at 2009Scape / RT4 Client

2024-10-29T03:27:46Z

Basically remove this if

https://gitlab.com/2009scape/rt4-client/-/blob/master/plugin-playground/src/main/kotlin/BasicInputQOL/plugin.kt?ref_type=heads#L61

Dan Ginovker opened issue #9: [ BasicInputQOL ] Zoom scroll should work without holding CTRL at 2009Scape / RT4 Client

2024-10-29T03:27:05Z

Make it match Runelite/OSRS default behavior (which more people are used to)

Dan Ginovker commented on merge request !28 at 2009Scape / RT4 Client

2024-10-15T01:40:07Z

Loot drop, xp tracker, hiscores all working great on Linux

Dan Ginovker commented on merge request !23 at 2009Scape / RT4 Client

2024-09-10T00:47:41Z

Latest commit is working well for me (on Linux). Changing display settings, logging in and out, restarting etc all work

Dan Ginovker commented on merge request !23 at 2009Scape / RT4 Client

2024-09-07T16:30:08Z

By "disable plugins" I'm not sure what you mean. Are you referring to editing the values?

It was just weird that I had some plugins configured from KondoKit, and some plugins configured outside of it. Obviously that has nothing to do with KondoKit, but this plugin is very much "This is the future" vibe, so it felt like all plugins should be made with it

Also were you able to get it working in all window modes or just resizableSD?

When clicking Standard Detail or High Detail, it says "RuneScape was unable to enter the chosen display mode."

For some reason KondoKit isn't appearing on the side today.. I ran the same commands as above, but this time startup has this line appearing:

Exception in thread "Thread-4" java.lang.NullPointerException: API.GetSprite(getSpriteId(i)) must not be null
        at KondoKit.HiscoresView.createHiscoreSearchView(HiscoresView.kt:369)
        at KondoKit.plugin$Init$1.run(plugin.kt:96)
        at java.base/java.lang.Thread.run(Thread.java:829)

Also I just noticed, everytime you resize the client, the plugins reload. Not sure if intentional.

Dan Ginovker commented on merge request !23 at 2009Scape / RT4 Client

2024-09-06T05:10:06Z

First thoughts feedback:

Dope
Resizing is a bit buggy, but not a blocker
Not being able to disable the plugins that are outside Kondokit is weird.. but not a blocker
Exp tracker is dope; seems to have an off-by-one error (i.e. If I'm 45xp away from leveling up prayer, then I bury a bone, it should say I have 2 actions left but it says I have 1 instead) (not a blocker)
Loot tracker is very dope
Not too OP
Would merge

Dan Ginovker commented on merge request !23 at 2009Scape / RT4 Client

2024-09-06T05:04:36Z

Kk fixed it:

Checked out 9624e73a
./gradlew build
mkdir client/plugins
cp -r plugin-playground/build/classes/kotlin/main/* client/plugins
./gradlew run
Login, type ::resizablesd

Dan Ginovker commented on merge request !23 at 2009Scape / RT4 Client

2024-09-06T01:42:35Z

How do you run it? I checked out your branch and did ./gradlew run but just got the regular client

edit: Nvm I typed ::resizablesd and it worked for a bit, but now it's just logging me out with the stack trace

java.lang.NullPointerException: API.GetSprite(getSpriteId(skillId)) must not be null
        at KondoKit.XPTrackerView.createXPWidget(XPTrackerView.kt:219)
        at KondoKit.plugin.OnXPUpdate(plugin.kt:251)
        at plugin.PluginRepository.lambda$OnXPUpdate$6(PluginRepository.java:162)
        at java.base/java.util.HashMap$Values.forEach(HashMap.java:977)
        at plugin.PluginRepository.OnXPUpdate(PluginRepository.java:162)
        at rt4.Protocol.readPacketInternal(Protocol.java:1454)
        at rt4.Protocol.readPacket(Protocol.java:2345)
        at rt4.Protocol.method1756(Protocol.java:2377)
        at rt4.client.mainLoop(client.java:1727)
        at rt4.GameShell.mainLoopWrapper(GameShell.java:472)
        at rt4.GameShell.run(GameShell.java:627)
        at java.base/java.lang.Thread.run(Thread.java:829)
Error: KondoKit.XPTrackerView.createXPWidget KondoKit.plugin.OnXPUpdate plugin.PluginRepository.lambda$OnXPUpdate$6:162 java.base/java.util.HashMap$Values.forEach:977 plugin.PluginRepository.OnXPUpdate:162 rt4.Protocol.readPacketInternal:1454 rt4.Protocol.readPacket:2345 rt4.Protocol.method1756:2377 rt4.client.mainLoop:1727 rt4.GameShell.mainLoopWrapper:472 rt4.GameShell.run:627 java.base/java.lang.Thread.run:829 | java.lang.NullPointerException: API.GetSprite(getSpriteId(skillId)) must not be null | T2 - 38,38,38 - 6,3106,9942 - -92,111,-126,0,1,3,

(possible I'm not running it right 😸)

Dan Ginovker deleted project branch webwalking_improvements_200524 at Dan Ginovker / IdleRSC-2

2024-06-16T22:18:07Z

Dan Ginovker (21132cc6) at 16 Jun 22:18