Note that the public_user_access permission needs to be removed entirely in a follow up MR.
Diane Russel (6e8989c9) at 18 Mar 20:39
Move read_project_for_iids to public_authenticated.yml
... and 89 more commits
We moved these permissions to the guest.yml role definition file but this whole condition isn't needed anymore because the admin_issue is only enabled for users who are members. This was probably a remnant of when admins returned false for the guest condition and needed to have permissions granted to them explicitly.
Diane Russel (67401817) at 18 Mar 20:00
Move admin_issue_relation to role YAML files
Diane Russel (e983ea3e) at 18 Mar 19:41
Revert admin_issue_relation to conditional rule
Diane Russel (4aacd812) at 18 Mar 19:39
Use role YAML files for downstream policy permissions
This MR adds the base public project permissions in YAML role files to match the pattern used by all other roles and fixes the logic so that public access doesn't enable guest access anymore.
| Before | After |
|---|---|
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Diane Russel (da710092) at 18 Mar 18:53
Move workaround permissions into guest.yml
... and 3 more commits
Diane Russel (354e275b) at 18 Mar 18:29
Merge branch 'ia-extract-auditor-permissions' into 'master'
... and 1 more commit
Diane Russel (93bc0076) at 18 Mar 18:29
Extract auditor permissions to a role definition file.
| Before | After |
|---|---|
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Looks good @imand3r although you have some merge conflicts
Refactor custom dashboard policy to use granular permissions
Replace reporter_access and developer_access checks in DashboardPolicy with delegated namespace conditions and specific permissions. Add custom dashboard permissions to reporter and developer role definitions. Update permission validation to support underscore-prefixed permission names.
| Before | After |
|---|---|
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #593274
Diane Russel (515f5647) at 18 Mar 16:45
Diane Russel (5835dfe8) at 18 Mar 16:45
Merge branch '593252-remove-owner-access-from-import-export-helpers...
... and 1 more commit