It doesn't look like UI code, it looks like Geom code. I would recommend putting it into the geom helpers.
Please squash all your commits and improve the commit message, don't mention adobe obviusly in the commit message ;)
Almost there.
This should now be fixed!
Thank you so much for testing @karliss1
Martin Owens (7ec9893d) at 16 Mar 18:23
Improve new Measure Path features and fix some issues
Ah I see the issue now. Thanks. Dragging from these points doesn't negate the PathMeasure mode even when it's no longer over the original path.
This is a backport of !7812 to test some sizing issues.
DO NOT MERGE
This hurts the number formatting, pastes two lib2geom functions and might have other unintended bugs.
OK after investigating, that ctrl click point nonsense is trash code. The feature needs to be removed and re-added in a less broken way. We'll move this off to some future MR. I could barely make it work without injecting values into class variables, I have no idea how the UX is supposed to work.
I couldn't make the brokenness you report. I believe that you see it though since it's pretty much the same result I got, but fixed. Question is though, how can I replicate it. Can you report any steps to reproduce?
Well that's frustrating. Thanks for clarifying, it's certainly not obvious or even evident in the code either. It must have been added on by someone later then the rest of the tool.
That bug is also a pain, I fixed it gdi and it was fixed. Now it's back. I hate when that happens.
Yes please. There's a ton of regressions in 1.5 that need fixing.
OK the measurement tool doesn't o what you've screenshotted here (at least I don't think it does) the angles are always against the horizon.
I've added in the basic functionality as you've described though. Clicking curves or angles will reposition the measure tool to that location.
when the measure tool get a third point, this can be expanded, but I'm calling it good for now.
Martin Owens (2880a072) at 15 Mar 19:49
Improve new Measure Path features and fix some issues
Martin Owens (8e051d46) at 15 Mar 18:52
A backport of the new measurement tools for testing
OK I got it to backport with a bit of elbow grease: !7813 (closed) when this is built you should be able to compare it. The main issue is the size of things.
This is a backport of !7812 to test some sizing issues.
DO NOT MERGE
This hurts the number formatting, pastes two lib2geom functions and might have other unintended bugs.
Martin Owens (c437631a) at 15 Mar 17:44
A backport of the new measurement tools for testing
... and 868 more commits
I tested scaling for both screen and zoom and I got a consistent response. There was some detection issues (see below) but the actual drawn shapes appear of good size at all levels... I wonder what's going on with your setup that makes the calculation produce such small output. :-/
All fixed, thanks for testing and getting a crash report to me.
I believe I just fixed this, the zoom adjustment was multiplied instead of divide. This net build should fix this.
Martin Owens (98014a7d) at 15 Mar 16:10
Improve new Measure Path features and fix some issues
... and 6 more commits
Interesting! Thanks fordemonstrating it.