I tried #1. Options, /#2 (closed) and /#3 (closed) requires specific new classes, which somehow, take value to the utility classes. I prefer to apply the style directly. More straight forward, in my opinion.

@tachyons-gitlab, I am sorry to bother you. There was a conflict with gitlab.pot just at the point of merge 🤦🏻 . Would you mind re-approving? Thanks! 🙏

I got this answer from Duo:

The base class OmniauthIdentityLinkerBase uses session = {} as the default, meaning it's treated as a plain Hash. So instance_double(Hash) is actually appropriate here — the production code only uses @session as a hash. The comment's suggestion of ActionDispatch::Request::Session would be over-specifying. The comment is wrong in this case.

noreferrer implies noopener, so rel='noreferrer' alone is sufficient. rel='noopener noreferrer' is redundant but commonly used for backwards compatibility with older browsers that didn't support noreferrer implying noopener.

https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel/noreferrer#description

Fixed, thanks!

@GitLabDuo, I tried hard to use a utility class but it is ovewrriden by a more specific class from boostrap. This was the only way.

Eduardo Sanz García (302bbea9) at 17 Mar 16:12

... and 1804 more commits

No problems, @tachyons-gitlab. Thanks for the approval!

Eduardo Sanz García (0188e070) at 17 Mar 15:55

Eduardo Sanz García (d115582d) at 17 Mar 15:54

... and 1 more commit

What does this MR do and why?

Add Gettext/ParameterCount RuboCop cop

Adds a new cop that detects _() and s_() calls with more than 1 parameter, and n_() calls that do not have exactly 3 parameters. This enforces the correct usage of gettext translation methods, which accept a fixed number of arguments by convention.

References

Related to:

• !226764
• !226732
• !227294

Screenshots or screen recordings

N/A

How to set up and validate locally

N/A

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Eduardo Sanz García (efcebee2) at 17 Mar 15:50

Eduardo Sanz García (80e6af1d) at 17 Mar 15:49

... and 1 more commit

What does this MR do and why?

Replace s_() for _() when namespace is missing

Automatic correction using the rule that will be introduce in !226732

On a second commit we make manual changes in a few strings related MemberRole namespace.

References

Screenshots or screen recordings

N/A

How to set up and validate locally

N/A

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Eduardo Sanz García (6b637192) at 17 Mar 15:38

... and 1038 more commits

@ashmckenzie, I have fixed the undercoverage for the new cop (see last commit). However, I didn't fix the undercoverage for error_not_verified which was touched because of the translation change in app/services/service_desk/custom_email_verifications/base_service.rb. I am going to label pipeline:skip-undercoverage .

Please, could you re-review? Thanks!

Eduardo Sanz García (79a2bc1a) at 17 Mar 15:27

... and 1039 more commits