Updated weight to 1.

@jayswain there is nothing to implement here since all required permissions (see Resources in the description) required to access Security dashboards (new and old) are already enabled for Security Managers.

Verification thread: #589682 (comment 3172967283)

cc @m-omokoh

Closing this one now.

Old group security dashboard is accessible:

New group security dashboard is accessible:

New project security dashboard is accessible:

Export is working:

Some recent changes allowed Security Managers to see (project level) Secure -> Security dashboard menu and access the page:

@jayswain could you perform the initial backend review for this MR, please? 🙏🏼

Eugie Limpin (a44b61ff) at 19 Mar 06:04

It doesn’t prove that the Security Manager path works without push rights (the intended behavior change), since it doesn’t explicitly ensure the user can’t push to the branch

Security Managers, by spec, can't push to branches.

Eugie Limpin (083d7d79) at 19 Mar 05:11

... and 216 more commits

Closing this now that !226807 (merged) is merged. FYI @jayswain @m-omokoh

Yeah, we should move this in ee/spec/. It's safe in the meantime because it's only used (as it should be) in ee/spec/policies/project_policy_spec.rb.

Thanks, @jayswain.

I've implemented view, create, update, and delete actions in !227866 but it looks like we still have to figure out how we can authorize Security Managers to run DAST on-demand scans without giving them code write access.

While working on the run action, I added create_pipeline permission for Security Managers but I got stuck because in addition the create_pipeline permission requirement, the user should also be allowed_to_write_ref? (can_update_branch? -> can_push_to_branch?(ref) || can_merge_to_branch?(ref)).

FYI @m-omokoh @mikeeddington @joelpatterson

Thanks for the thorough review, @ccharnolevsky!

@drosse could you review as frontend maintainer, please?

@jayswain don't forget to assign a reviewer (/request_review @username) 🙏🏼

We need Verify approval (and Hinam has a lot of ongoing reviews) so let's ask @panoskanell instead.

Eugie Limpin (7eb0920f) at 19 Mar 01:32

... and 1 more commit