Thank you @melroy89 for another nice and minimally scoped update
Emergent Reasons (ebbfe329) at 02 Mar 15:10
Merge branch 'update_packages' into 'master'
... and 1 more commit
better-sqlite3, dompurify and webpack-cli
nvm, node version manager. Plus format markdown file correctly.Follow-up from: !94
better-sqlite3, dompurify and webpack-cli
nvm, node version manager. Plus format markdown file correctly.Follow-up from: !94
I'll approve and merge after doing some additional tests to confirm campaigns can complete.
@monsterbitar figure you would want to take a quick look at this one. It all looks fine to me on paper, but I haven't tested yet. FWIW I get the same package-lock as this MR if I do npm install.
@melroy89 have you tested that this still works with the updates? Thank you for these minimally scoped updates.
Note for @monsterbitar this is the npm ci result:
Checking with Corentin if we should leave or remove that note in the readme since we are touching those lines.
Next follow up: !95 (merged)
better-sqlite3, dompurify and webpack-cli
nvm, node version manager. Plus format markdown file correctly.Follow-up from: !94
-y (yes) flag.gitlab-ci.yml file.prettierignore file and exclude the static directory, which contains js/cdn directory we do not care about. Do we want to format maybe static/js/create.js?package.json for both eslint as well as prettier (which is only checking, not fixing)
No production changes, only formatting.
Rationale: Enforcing formatting tool like prettier helps to write the same kind of code style. Making it easier to work together with a large team, especially in case of merge conflicts or working with diffs. Which might help now. especially since we would like to bump up all npm deps packages, npm major releases, Node.js version, etc.
First step in: #112
Emergent Reasons (1be5272c) at 28 Feb 15:08
Merge branch 'start_with_running_prettier' into 'master'
... and 1 more commit
@melroy89 I was able to upgrade to node 24 with no issues. Only three packages were needed to be updated to fix security issues.
diff --git a/package.json b/package.json
index d1c1db8..c82fcb3 100644
--- a/package.json
+++ b/package.json
@@ -18,12 +18,12 @@
"dependencies": {
"@bitauth/libauth": "^1.18.1",
"async-mutex": "^0.3.2",
- "better-sqlite3": "^9.1.1",
+ "better-sqlite3": "^11.10.0",
"body-parser": "^1.20.2",
"canvas-confetti": "^1.4.0",
"cors": "^2.8.5",
"debug": "^4.3.2",
- "dompurify": "^2.3.2",
+ "dompurify": "^3.3.1",
"electrum-cash": "^2.0.8",
"express": "^4.17.1",
"express-sse": "0.5.1",
@@ -34,6 +34,6 @@
"webpack-cli": "^4.8.0"
},
"devDependencies": {
- "eslint": "^8.3.0"
+ "eslint": "^10.0.1"
}
}
-y (yes) flag.gitlab-ci.yml file.prettierignore file and exclude the static directory, which contains js/cdn directory we do not care about. Do we want to format maybe static/js/create.js?package.json for both eslint as well as prettier (which is only checking, not fixing)
No production changes, only formatting.
Rationale: Enforcing formatting tool like prettier helps to write the same kind of code style. Making it easier to work together with a large team, especially in case of merge conflicts or working with diffs. Which might help now. especially since we would like to bump up all npm deps packages, npm major releases, Node.js version, etc.
First step in: #112
If you're ok with it as-is, please resolve the thread and I'll merge.
Reviewed all the changes. LGTM.
Appreciate getting things back into clean shape
let's not make unnecessary changes at this point
we could also rename the stage, to like test instead of lint. which is more common name, and a default in GitLab. If you wish.