Yep, LGTM
Fixes non-auto-correctable Style/NumberedParameters offenses
| Before | After |
|---|---|
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #589138
@timofurrer Hi Timo! Are you available for a maintainer review?
Yep! LGTM
feature_issue_url to https://gitlab.com/gitlab-org/gitlab/-/issues/589482
rollout_issue_url to #593909 (newly created)/issues/0 URLs that were merged with !227515
@cwoolley-gitlab @egrieff So sorry, I had to do a rebase and d3d369b5 broke some tests :( Could I get another check?
@daniel-prause bump
Gary Holtz (e2168b07) at 17 Mar 18:53
Gary Holtz (9544a11d) at 17 Mar 18:53
Merge branch 'renovate/commitlint-cli-20.x' into 'main'
... and 1 more commit
This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| @commitlint/cli (source) | dependencies | minor | ^20.4.4 -> ^20.5.0 |
⚠️ WarningSome dependencies could not be looked up. Check the warning logs for more information.
MR created with the help of gitlab-org/frontend/renovate-gitlab-bot
v20.5.0
Note: Version bump only for package @commitlint/cli
Note: Version bump only for package @commitlint/cli
Note: Version bump only for package @commitlint/cli
This MR has been generated by Renovate Bot.
LGTM!
This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| @commitlint/cli (source) | dependencies | minor | ^20.4.4 -> ^20.5.0 |
⚠️ WarningSome dependencies could not be looked up. Check the warning logs for more information.
MR created with the help of gitlab-org/frontend/renovate-gitlab-bot
v20.5.0
Note: Version bump only for package @commitlint/cli
Note: Version bump only for package @commitlint/cli
Note: Version bump only for package @commitlint/cli
This MR has been generated by Renovate Bot.
@nbelokolodov I think after taking another look at this, we can probably close it for now unless we have a specific reason to open it again
Adds metrics for command usage for the glab CLI.
| Before | After |
|---|---|
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
@davidhampgonsalves Mainly from Stan's comment here https://gitlab.com/gitlab-org/gitlab/-/work_items/499189#note_2316787145
but merge_request_diff_commits has 9 columns, so 1000 rows is only 9000 params per insert which seems like it still has lots of space to work with!
Gary Holtz (ae54300e) at 16 Mar 20:41
refactor(mr/checkout): inject GitRunner dependency for testability
Gary Holtz (54b0c01f) at 16 Mar 20:38
refactor(mr/checkout): inject GitRunner dependency for testability
... and 1 more commit
Gary Holtz (e9f64089) at 16 Mar 20:36
Merge branch 'main' into '7707-convert-mr-checkout-tests-to-newer-s...
... and 54 more commits