Hubert Huang (e89102f1) at 19 Mar 14:44

Hubert Huang (0adc3695) at 19 Mar 14:38

Hubert Huang (e0e6bf79) at 19 Mar 01:13

Hubert Huang (047a27bd) at 19 Mar 01:09

What does this MR do and why?

Adds test coverage for the skeleton loader's dynamic :class and :style bindings in the FileRow component. Specifically:

• Tests that fileRowContainerClassList applies the alignment class when showTreeToggle is true
• Tests that fileRowContainerClassList does not apply the alignment class when showTreeToggle is false
• Tests that the --level CSS custom property is set from file.level for correct indentation

References

• Follow-up to !226293
• Addresses non-blocking review feedback from @lorenzvanherwaarden
• Related to #584240

Screenshots or screen recordings

No UI changes — test-only MR.

How to set up and validate locally

1. Run the test file:

   yarn jest spec/frontend/vue_shared/components/file_row_spec.js

2. Verify the three new tests in the Skeleton loader describe block pass.

Hubert Huang (16f4f569) at 19 Mar 00:40

Hi @arturoherrero, I noticed that the pipeline failed. I rebased the source branch, but the pipeline still failed. The failures are all CI infrastructure issues, not related to our changes:

• rspec-ee unit pg17 es8 33/39 - All 3590 tests passed (0 failures), but the job exceeded the 1h30m runner timeout during post-processing
• rspec-ee system pg17 pgvector17 es8 3/16 - Also hit the 1h30m timeout

What would be the best plan of action?

Hubert Huang (1f512dec) at 18 Mar 19:39

... and 232 more commits

Hubert Huang (99fba36f) at 18 Mar 19:26

Hubert Huang (408a96d3) at 18 Mar 19:26

@arturoherrero Yes, you are correct!

@dgruzd Thank you for the feedback! Just applied the suggestion!

Hubert Huang (26f9c42c) at 18 Mar 16:00

After the CI pipeline failed, I reverted the changes to ee/lib/elastic/migration.rb, ee/app/models/elastic/migration_record.rb, and ee/lib/search/cluster_health_check/elastic.rb back to using helper.client. Gitlab::Search::Client only delegates a subset of Elasticsearch client methods, and these files require methods that are not delegated:

• migration.rb — subclasses call client.cluster (not delegated)
• cluster_health_check/elastic.rb — calls client.nodes (not delegated)
• migration_record.rb (instance client method) — calls client.get (not delegated)

The remaining files only use delegated methods (search, delete, delete_by_query, cat, index, indices) and have been updated to use Gitlab::Search::Client.new.

Let me know your thoughts or if you have any suggestions on how to handle the files that use non-delegated methods.

Hubert Huang (3ebd25b0) at 18 Mar 02:03

Hubert Huang (35772bd8) at 18 Mar 01:04

Hubert Huang (0ba843a9) at 18 Mar 00:40

... and 348 more commits

Hubert Huang (2045d459) at 17 Mar 21:56

@GitLabDuo Wouldn't the ||= operator ensures Gitlab::Search::Client.new is assigned only if @client is nil? That means it shouldn't matter whether Gitlab::Search::Client.new returns a singleton/cached instance, right?