This is live on production (18.10 release)

CC: @mclausen35 @ajbiton @cbazan1

@sming-gitlab Absolutely! This LGTM 👍

What does this MR do and why?

This MR updates the actor for all mr_reports_tab FF reference to be project instead of current_user.

There is no UI/UX changes, everything continues to work expected:

mr_reports_tab true	mr_reports_tab false

mr_reports_tab true

• Has "Reports" tab
• Display "View reports"
• Widget is not expandable

mr_reports_tab false

• No "Reports" tab
• Widget is expandable

References

Screenshots or screen recordings

Before	After

How to set up and validate locally

1. Clone this repo and create a MR similar to this: gitlab-org/govern/threat-insights-demos/frontend/mr-reports-tab!1
2. Trigger a pipeline and it will create some findings

Enable and disable FF:

http://gdk.test:3000/rails/features/mr_reports_tab

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #592500

Thought (non-blocking): It seems like we use "20" as a pretty standard spacing throughout these files- might be nice to put it in a constant at some point?

What does this MR do and why?

Adds support for rendering a vulnerabilities by age chart in PDF vulnerability export reports. This enables users to visualize the distribution of vulnerabilities by their age when exporting security reports.

References

Screenshots or screen recordings

Before	After

How to set up and validate locally

1. Create a group with vulnerabilities
   • Create a group and add a project with vulnerabilities
   • Navigate to the group's Security Dashboard
   • Click Export and verify the vulnerabilities by age chart is present in the PDF
2. Verify project-level export excludes the chart
   • Navigate to the same project's Security Dashboard
   • Click Export and verify the vulnerabilities by age chart is NOT present in the PDF (only available at group level)

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #593068

Sorry @bryan_valdiviezo - I had this review written but never published it 🤦

I don't have much to suggest from my side. Rendering looks good 👍

Thanks @bwill! I applied your suggestions- WDYT?

Updated this 👍

Made this change

Harrison Peters (8b06b990) at 16 Mar 18:47

... and 1 more commit

Harrison Peters (e13c3765) at 16 Mar 16:47

Totally agree! Happy to address this 👍

What does this MR do and why?

Adds support for rendering a vulnerabilities over time chart in PDF vulnerability export reports.

References

Screenshots or screen recordings

Before	After

How to set up and validate locally

For Group:

1. Set up test data:
   • Create a group with at least one project
   • Ensure the project has vulnerabilities (you can create test vulnerabilities or run security scans)
2. Export the PDF:
   • Navigate to the Security Dashboard for the group or project
   • Click the Export button
3. Validate:
   • Download the exported PDF
   • Verify that the vulnerabilities over time is rendered correctly
   • Check that the chart displays the correct data and formatting

For Project:

1. Set up test data:
   • Create a project with vulnerabilities
2. Export the PDF:
   • Navigate to the Security Dashboard for the project
   • Click the Export button
3. Validate:
   • Download the exported PDF
   • Verify that the vulnerabilities over time is rendered correctly and that total is score is not present
   • Check that the chart displays the correct data and formatting

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #592952

@bryan_valdiviezo On my local it's rendering a little funky again but overall LGTM!

I checked out Ugo's points from the previous MR and I think they're all addressed here as well 👍

Looks good! The graph out of bounds from it's grey background again though 🤔

I can see in the example this is not the case so perhaps it's another local issue?

Harrison Peters (46dbfcb4) at 13 Mar 16:24

@bwill @subashis The field is now only exposed on the VulnerabilityType

This isn't a new query- I just moved it into a separate method

Harrison Peters (18cb0a9e) at 13 Mar 14:19