Joe Knapper (ac21a604) at 18 Mar 16:47

Joe Knapper (91075af7) at 18 Mar 16:13

Bug report

Summary

• I have searched existing issues to ensure this hasn't been reported.

Expected Behaviour: mypy passes / has same results to Linux Current Behaviour: <!-- Summarise what happened instead -->src\openflexure_microscope_server\stitching.py:228: error: Module has no attribute "SIGKILL"; maybe "SIGILL"? [attr-defined]`

Configuration

Component	Value
Server Version	v3
Release/Branch	v3.0.0-alpha4
Operating System	e.g. Windows 11
Python Version	e.g. Python 3.13.6

Steps to reproduce

Running mypy fails because SIGKILL is Linux only

Reproducibility:

• Consistent: Happens every time.
• Intermittent: Happens roughly [X]% of the time or every [X] scans/clicks.
• One-off: Only happened once so far.

Relevant logs and/or screenshots

Additional details

Closes #729 by adding explicit windows check before calling SIGKILL

Merge checklist:

• All new/changed functions have up to date typehints and docstrings
• Any UI updates have a before and after screenshot in the MR description
• Unit testing of new functionality has similar or better coverage than similar existing code
• This code has been tested on a microscope
  • Webapp has been recompiled, with aesthetic changes checked in light and dark mode (if changed)
  • With updated settings JSON (if changed)
  • SmartScan and live stitching work

Joe Knapper (8bc05ed8) at 18 Mar 16:13

... and 3 more commits

Closes #729 by adding explicit windows check before calling SIGKILL

Merge checklist:

• All new/changed functions have up to date typehints and docstrings
• Any UI updates have a before and after screenshot in the MR description
• Unit testing of new functionality has similar or better coverage than similar existing code
• This code has been tested on a microscope
  • Webapp has been recompiled, with aesthetic changes checked in light and dark mode (if changed)
  • With updated settings JSON (if changed)
  • SmartScan and live stitching work

Joe Knapper (91075af7) at 18 Mar 14:51

Closes #730

Before

After

Also works for notifications

This MR contains the following

• Updates css to include word breaks in uikit notifications

Merge checklist:

• All new/changed functions have up to date typehints and docstrings
• Any UI updates have a before and after screenshot in the MR description
• Unit testing of new functionality has similar or better coverage than similar existing code
• This code has been tested on a microscope
  • Webapp has been recompiled, with aesthetic changes checked in light and dark mode (if changed)
  • With updated settings JSON (if changed)
  • SmartScan and live stitching work

Closes #730

Before

After

Also works for notifications

This MR contains the following

• Updates css to include word breaks in uikit notifications

Merge checklist:

• All new/changed functions have up to date typehints and docstrings
• Any UI updates have a before and after screenshot in the MR description
• Unit testing of new functionality has similar or better coverage than similar existing code
• This code has been tested on a microscope
  • Webapp has been recompiled, with aesthetic changes checked in light and dark mode (if changed)
  • With updated settings JSON (if changed)
  • SmartScan and live stitching work

Joe Knapper (e703ce06) at 18 Mar 14:33

Note this is build upon !530 That should be merged first

This is a second attempt to create a generic action tab so that we can reuse some of the smart scan tab's functionality without copying the tab.

It uses code and lessons learned from !512, but is built upon !530. There were too many significant conflicts to do a direct rebase.

This MR contains the following

• Create actionTab that can poll and action and show a log and optionally a mini stream
• Use actionTab to make the slideScanTab
• Split slideScanControls out of slideScanTab
• Update polling logic of action button and allow action button to be forced to a specific task id (useful if creating it to cancel and ongoing action)

UI changes:

Before: (while scanning)

After: (while scanning)

Before: (after scanning)

After: (after scanning)

Merge checklist:

• All new/changed functions have up to date typehints and docstrings
• Any UI updates have a before and after screenshot in the MR description
• Unit testing of new functionality has similar or better coverage than similar existing code
• This code has been tested on a microscope
  • Webapp has been recompiled, with aesthetic changes checked in light and dark mode (if changed)
  • With updated settings JSON (if changed)
  • SmartScan and live stitching work

Haven't managed to break this

Joe Knapper (06182638) at 18 Mar 14:12

Closes #729 by adding explicit windows check before calling SIGKILL

Merge checklist:

• All new/changed functions have up to date typehints and docstrings
• Any UI updates have a before and after screenshot in the MR description
• Unit testing of new functionality has similar or better coverage than similar existing code
• This code has been tested on a microscope
  • Webapp has been recompiled, with aesthetic changes checked in light and dark mode (if changed)
  • With updated settings JSON (if changed)
  • SmartScan and live stitching work

Joe Knapper (1f43d1cc) at 18 Mar 12:41

This is fixed with a combination of !546 (merged) and raspberry-pi-os-image-customiser!24 (merged)

This builds, boots and scans fine, it's around 150MB smaller