What does this MR do?
Abstract square avatar border radius into two new design tokens.
avatar.square.border.radius.defaultavatar.square.border.radius.lg
Use the design tokens in the avatar component.
Removes override on the breadcrumb component to inherit the changes.
Screenshots or screen recordings
| Before | After |
|---|---|
 |
 |
 |
 |
patch for review — ill add better screenshot coverage in a separate issue / MR
--- a/packages/gitlab-ui/src/components/base/avatar/avatar.stories.js
+++ b/packages/gitlab-ui/src/components/base/avatar/avatar.stories.js
@@ -119,6 +119,20 @@ FallbackOnAvatarLoadFailure = (args, { argTypes }) => ({
});
FallbackOnAvatarLoadFailure.args = { ...generateProjectFallbackProps(), ...generateImageProps() };
+export const NonSquareImageAllSizes = () => ({
+ components,
+ template: `
+ <div class="gl-flex gl-gap-3 gl-items-center">
+ <gl-avatar
+ v-for="size in [16, 24, 32, 48, 64, 96]"
+ :key="size"
+ :size="size"
+ shape="rect"
+ src="proxy.php?url=./img/avatar_non_square.jpg"
+ />
+ </div>
+ `,
+});
+
export const AllIdenticons = () => ({
components,
template: `Integrations
- GitLab: mr_url
- CustomersDot: mr_url
- Duo UI: mr_url
- Status Page: mr_url
- Docs: mr_url
- Switchboard: mr_url
Does this MR meet the acceptance criteria?
This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.
Toggle the acceptance checklist
Conformity
-
The “What does this MR do?” section in the MR description is filled out, explaining the reasons for and scope of the proposed changes, per “Say why not just what”.
- For example, if the MR is focused on usage guidelines, addressing accessibility challenges could be added in a separate MR.
- Relevant label(s) are applied to the MR.
- The MR is added to a milestone.
-
Added the
~"component:*"label(s) if applicable. - A changeset is added when this MR will do a patch, minor, or major update. More information can be found in doc/publishing-packages.md.
Components
- GitLab UI's contributing guidelines.
- If the MR changes a component's API, integration MR(s) have been opened (see integrations above).
Documentation
- If creating a new component page from scratch, it follows the page template structure.
- Content follows the GitLab Documentation Style Guide when appropriate.
- Related pages are cross-linked, where helpful. Component pages have related components and patterns defined in their Markdown front matter.
- If embedding a Figma file, it follows the Figma embed guide.
- Review requested from any GitLab designer or directly from a maintainer or trainee maintainer.
- Maintainer review follows the Pajamas UX maintainer review checklist.
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention
@gitlab-com/gl-security/appsec - Security reports checked/validated by a reviewer from the AppSec team
Accessibility
If this MR adds or modifies a component, take a few moments to review the following:
- All actions and functionality can be done with a keyboard.
- Links, buttons, and controls have a visible focus state.
-
All content is presented in text or with a text equivalent. For example, alt text for SVG, or
aria-labelfor icons that have meaning or perform actions. -
Changes in a component’s state are announced by a screen reader. For example, changing
aria-expanded="false"toaria-expanded="true"when an accordion is expanded. - Color combinations have sufficient contrast.
Related to #3363