Jacques Erasmus (1df6e77e) at 17 Mar 11:34

... and 1 more commit

Jacques Erasmus (b17fa004) at 17 Mar 11:33

What does this MR do?

DiffDiscussionRow now emits a start-thread event instead of calling the store directly. The adapter handles the event and resolves lineChange, lineCode, and lineRange from the DOM before passing them to addNewLineDiscussionForm, which stores them on the form object.

Why?

lineChange and lineCode is used in the legacy notes to create new notes. This data can only be resolved from the DOM at the moment the user opens a thread. The adapter has access to the DOM row; the Vue component and store do not.

Followed by: !226177

@slashmanov you're right!

It's getting hard to distinguish between rapid and non-rapid diffs these days 🙈

Thanks @slashmanov! The changes LGTM 👍

What does this MR do?

DiffDiscussionRow now emits a start-thread event instead of calling the store directly. The adapter handles the event and resolves lineChange, lineCode, and lineRange from the DOM before passing them to addNewLineDiscussionForm, which stores them on the form object.

Why?

lineChange and lineCode is used in the legacy notes to create new notes. This data can only be resolved from the DOM at the moment the user opens a thread. The adapter has access to the DOM row; the Vue component and store do not.

Followed by: !226177

Jacques Erasmus (4bbe7d47) at 17 Mar 09:48