Jose Ivan Vargas (0f2df2f9) at 17 Mar 17:28

... and 586 more commits

Jose Ivan Vargas (325140c2) at 17 Mar 17:21

... and 1418 more commits

Jose Ivan Vargas (d1093bb0) at 17 Mar 17:19

... and 1 more commit

What does this MR do and why?

Tiny UI improvements to make my life easier one click at a time:

Screenshots or screen recordings

Before:

After:

Before:

After:

How to set up and validate locally

• Go to yourgitlab.com/project_path/-/jobs/JOB_ID/artifacts/browse
  • Where JOB_ID is ID of job with artifact files.
  • There should be download button for each file (not for directory)
• Go to yourgitlab.com/project_path/-/jobs?kind=BUILD
  • There should be link to artifact browser for jobs that have artifacts

@csaez-ext I have replies and updates to your items

When I click Set up CI pipeline duo opens with this prompt on the chat Analyze this repository and generate a CI/CD pipeline Could we change the prompt to be Analyze repository to create a working and fully functional pipeline

Done ✅

After the prompt is sent, Duo attempts to respond, but then nothing happens. Is this connected with the AI Agent we are building, or isn't it connected yet?

Chances are this is your GDK running into issues when using AI features. The Duo Chat should use the default agent when the Pipeline Authoring agent is not available, I'm pretty sure there's something that's happening on our GDK that's now allowing you to see the responses.

For comparison this is my GDK

• Currently, when there isn't enough horizontal space to fit all actions in the repository toolbar (branch selector, Find file, Set up CI Pipeline, Code), the "Set up CI Pipeline" button is dropped entirely, while the other buttons remain in a weird order. The correct behavior should be - when the toolbar runs out of space, lower-priority actions should collapse into the existing overflow menu (the ... button). "Set up CI Pipeline" should be one of the hidden ones, but still accessible, not removed.

Now this one is tricky this weird order that you mention because there are multiple items in this page owned by multiple teams, changing this to set the button as a higher priority than others we risk causing issues to other teams. I'd suggest we stick to this order as I followed what other teams have done which is any item that gets added here will not show up on small to mobile viewports as the default options e.g. Find File, Code, Add File are the essential options that have to remain available in that order; For example the lock file and lock directory buttons will remain hidden even if we consider them higher priority as they're not part of the essentials

What do you think?

• Project information should appear below the repository toolbar On desktop, Project information lives in the right sidebar, it's supplementary content. When the layout collapses to a single column, the repository toolbar (branch selector, Find file, Set up CI Pipeline, Code) should come first since it's what users act on. Project information should follow below it.

I think this warrants a larger discussion with the larger UX team and the teams that own parts of this page, the rationale is sound but I'd suggest we skip these changes for now as we risk changing the expectations of other teams without input. Not to mention that this will make this small MR larger 😅

Let me know if you have any further comments or questions!

Let me know what's the final decision on the button title, Setup up GitLab CI/CD is consistent with the branding and communication style we have presented for the feature for the longest time 😄

frontend looks good to me, @syarynovskyi let me know if you need help merging this one

What does this MR do and why?

Update Premium billing page to adapt trial flow changes

References

Screenshots or screen recordings

Before	After

How to set up and validate locally

• Setup gdk to simulate SaaS - https://docs.gitlab.com/ee/development/ee_features.html#simulate-a-saas-instance and restart GDK
• Sign in as root. Create new group.
• In admin section update plan to be premium.
• Visit /-/billings page.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #587958

Jose Ivan Vargas (28809a98) at 17 Mar 16:25

Jose Ivan Vargas (5e8124b5) at 17 Mar 16:24

... and 1 more commit

What does this MR do and why?

Fix pipeline secondary link

Fixes issue where schedule link was not showing up due to missing data in GraphQL.

Changelog: fixed

References

Screenshots or screen recordings

Before	After

How to set up and validate locally

1. Visit Build > Pipelines
2. Trigger a scheduled pipeline
3. Ensure the schedule description shows up for secondary link and is routed correctly

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #589262

This looks good to me, thank you for your contribution @harvie. Setting this to auto-merge

Jose Ivan Vargas (5e169ac3) at 17 Mar 15:56

Jose Ivan Vargas (f149653b) at 17 Mar 15:56

... and 1 more commit

This MR contains the following updates:

Package	Type	Update	Change
dompurify	devDependencies	patch	3.3.2 -> 3.3.3

MR created with the help of gitlab-org/frontend/renovate-gitlab-bot

---

Release Notes

cure53/DOMPurify (dompurify)

v3.3.3: DOMPurify 3.3.3

Compare Source

• Fixed an engine requirement for Node 20 which caused hiccups, thanks @​Rotzbua

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this MR and you won't be reminded about this update again.

---

• If you want to rebase/retry this MR, check this box

---

This MR has been generated by Renovate Bot.

What does this MR do and why?

Tiny UI improvements to make my life easier one click at a time:

Screenshots or screen recordings

Before:

After:

Before:

After:

How to set up and validate locally

• Go to yourgitlab.com/project_path/-/jobs/JOB_ID/artifacts/browse
  • Where JOB_ID is ID of job with artifact files.
  • There should be download button for each file (not for directory)
• Go to yourgitlab.com/project_path/-/jobs?kind=BUILD
  • There should be link to artifact browser for jobs that have artifacts

What does this MR do and why?

Fix pipeline secondary link

Fixes issue where schedule link was not showing up due to missing data in GraphQL.

Changelog: fixed

References

Screenshots or screen recordings

Before	After

How to set up and validate locally

1. Visit Build > Pipelines
2. Trigger a scheduled pipeline
3. Ensure the schedule description shows up for secondary link and is routed correctly

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #589262

Jose Ivan Vargas (67feb7d0) at 13 Mar 17:58

... and 1319 more commits

The feature flag is owned by groupgitaly. @jcaigitlab For your review

@fforster Do you still need Drew and I assigned to this issue or can we defer to John for this one?

frontend looks good to me, let me know if you need help merging this one @pburdette