Sorry realized you're not a db maintainer, unassigning
@OmarQunsulGitlab Could you take over please? Thanks!
@dstull Would you be able to take over for the maintainer db approval? It was already approved prior but was reset due to a recent commit unrelated to the db changes...
If you do have further feedback could we do it in a follow up (assuming non-blocking) as @kherman1 will be helping taking over and implementing the first backend event while I'm OOO
Hi @sroque-worcel, sorry I'm at capacity for today
@Kaveh_Nejad_Gitlab Can you please take over for the initial? Thanks
@kherman1 Since I asked you for the handoff, would you mind giving the dev docs a review? This should help clarify the current state/usage of the activation engine. Thanks!
Add developer docs for activation engine
Adds index and quick start guide for activation engine
Changelog: changed
| Before | After |
|---|---|
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Jay Montal (0055bd35) at 05 Mar 23:38
Add developer docs for activation engine
Jay Montal (c3a08e33) at 05 Mar 23:33
Add developer docs for activation engine
... and 5 more commits
Jay Montal (6c5ce091) at 05 Mar 22:59
Fix db schema migration
Jay Montal (1c3688d0) at 05 Mar 22:51
Update milestone
Jay Montal (8f92b2b5) at 05 Mar 22:50
Update milestone
Hi @arpitgogia, could you re-approve and MWPS? Thank you!
@lma-git Thank you, do you mind taking another look?
Thanks for the updates here, lgtm
@pgascouvaillancourt Can you please take over for the maintainer review? Thanks!
Change lodash imports syntax to imitate lodash-es in EE files. This change replaces imports that look like:
import util from'lodash/util';
with the format used by
import { util } from 'lodash';
This aids with code consistency.
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Jay Montal (cb6e3f42) at 05 Mar 19:02
Update milestone
Jay Montal (8c7444f1) at 05 Mar 02:55
Updates based on further feedback