Kerri Miller (057684a2) at 17 Mar 02:29

Kerri Miller (8cb32029) at 17 Mar 02:28

... and 1 more commit

What does this MR do and why?

This method has been identified as unused, and thus a target for removal.

Related to #420057

Kerri Miller (c63e500e) at 16 Mar 19:18

Kerri Miller (f3f8d2ee) at 16 Mar 19:14

@mfanGitLab ah! yes.. I was trying to make the FF portion a bit more obvious, and had a little left over bit here.. good catch.

What does this MR do and why?

Adds a helper method that looks up pipelines by ID, first attempting to search within the current partition for improved query performance when partition pruning is enabled, then falling back to a global search if not found.

This allows PostgreSQL to prune irrelevant partitions and reduces query cost for the common case where the pipeline belongs to the current partition.

The change is gated behind the existing ci_partition_pruning_workers feature flag, added in !227525

Kerri Miller (96989a93) at 16 Mar 18:22

... and 1 more commit

@minac Personally, I like to keep the application and the test suite from becoming too entangled; I think of the specs as their own application. Since the fixture would never be executed in the context of the application as part of it's normal (non-testing) functions, my strong-opinion-weakly-held is that we should probably find a home for it somewhere in the [ee/]spec/ world.

@minac weird, I looked and didn't see it in our app, and google wasn't helping me.. thanks

I'm really curious to know; what makes you assume this?

@minac I didn't mean it in a derogatory or negative way - apologies for it coming across with that tone! What I meant was more.. this is a LOT of code to review in one gulp, it's all coming in one single commit, and there's not a lot of here; it lands as a complete solution from the get-go, rather than an MVP with clear signs of evolution. Whether that's good or bad is in the product, I really just meant that phrase as an aside, neither commentary nor judgement.

What do you think about this change?

This is similar to a spike I did last year, using logging to trace usage while working on driving out unused code. I left some Dumb Questions, but in general this is a giant lump of code (prompted, I assume.) Since it's fairly divergent from the main app, did you consider releasing this as an internal gem?

WDYT about adding logging of non-authorized call sites for production?

This is a case where I think it would be beneficial to prioritize adding docs.

Sorry, where is the source for this? 🙃

Can you expand on why this in in lib/ rather than with other testing fixtures?

Seeing this repeated over and over again, why not add this to the .rubocop_todo or exempt it at the source?

@ghinfey teeny tiny maintenancerefactor MR - could you maintainerize? 🙇

Kerri Miller (3ff05b0a) at 13 Mar 17:43

What does this MR do and why?

Adds a missing feature_category that I noticed in passing.

Ah... why did roulette recommend someone on PTO? 🙃

@cwoolley-gitlab could you maintainerize this? It's tiny!

@charlieeekroon could you maintainerize this small maintenanceremoval MR? 🙇