hey @nao.hashizume, this isn't urgent but could you please review this MR? 🙇

@nao.hashizume, because Andrew is about to be unavailable, could you take over the review please? 🙇

Kev Kloss (2ea0f111) at 18 Mar 17:17

... and 31 more commits

It doesn't due to:

Errno::ENOENT: No such file or directory @ rb_sysopen - /etc/gitlab/gitlab-workhorse/secret

They're mostly IO-bottlenecked though, so IDK. I just increased it to be sure.

I presume so?

What

This removes the limits on the webservice and toolbox because they are inconvenient for development.

This also loosens limits for other services to avoid resource bottlenecks.

Links to relevant issues

Kev Kloss (001b4875) at 18 Mar 16:55

Kev Kloss (ac8857e6) at 18 Mar 16:51

Kev Kloss (b94336db) at 18 Mar 16:51

... and 1 more commit

This MR writes each process's output to its own log file when running caproni run, e.g. logs/puma.log.

Related to gitlab-org/quality/tooling/team#249

How to validate locally

1. Check out this branch
2. In caproni-demo/monolith-edit-mode, run caproni run
3. Verify log files are created per process (e.g. cat logs/puma.log)

thanks @nao.hashizume, LGTM! 🙌

This MR writes each process's output to its own log file when running caproni run, e.g. logs/puma.log.

Related to gitlab-org/quality/tooling/team#249

How to validate locally

1. Check out this branch
2. In caproni-demo/monolith-edit-mode, run caproni run
3. Verify log files are created per process (e.g. cat logs/puma.log)

What

This adds tests for the internal/telemetry module.

Why

We didn't have tests before.

Links to relevant issues

Kev Kloss (6ee2090c) at 18 Mar 16:34

What

This moves the hooks logic for the edit_mode_prepare hooks.

Why

Makes the code easier to follow and change.

Links to relevant issues

See #13

Kev Kloss (dbd7d2cc) at 18 Mar 15:00

Kev Kloss (10f90254) at 18 Mar 14:37

Kev Kloss (92ea40e7) at 18 Mar 14:29