I think this might be causing one of the spec failures because it doesn't match the text in registration_enabled_callout?

  let_it_be(:callout_title) { _('Check the restrictions for new users') }

Thanks @sselhorn, also left a few minor suggestions for the UI text. Thanks for tackling this update, it is a lot.

I'm fine with the mix of 'prevent' and 'disable' in the docs for searching purposes, I think it can help folks find the content.

Should we change this too?

      'ApplicationSettings|Only users with email addresses that match these domains can create accounts. Wildcards allowed. Enter multiple entries on separate lines. Example: domain.com, *.domain.com',

It's nitpicky, but this text refers to the checkbox we've renamed to Allow new user accounts. To make the connection more explicit, what do you think about this:

          'ApplicationSettings|Any user that visits %{host} and creates an account must be explicitly approved by an administrator before they can sign in. Only effective if new user accounts are allowed.',

Kati Paizee (ebd21985) at 17 Mar 06:14

... and 1 more commit

Kati Paizee (dfb3b6a1) at 17 Mar 06:14

What does this MR do?

For: #585946, let's provide some help with what we mean when we use the term "relation".

Result:

• https://docs.gitlab.com/upstream-review-mr-ee-226007/api/group_relations_export/
• https://docs.gitlab.com/upstream-review-mr-ee-226007/api/project_relations_export/
• https://docs.gitlab.com/upstream-review-mr-ee-226007/user/group/import/#estimating-migration-duration
• https://docs.gitlab.com/upstream-review-mr-ee-226007/user/group/import/troubleshooting/#source-instance

Author's checklist

• Optional. Consider taking the GitLab Technical Writing Fundamentals course.
• Follow the:
  • Documentation process.
  • Documentation guidelines.
  • Style Guide.
• If you're adding a new page, add the product availability details under the H1 topic title.
• If you are a GitLab team member, request a review based on:
  • The documentation page's metadata.
  • The associated Technical Writer.

If you are a GitLab team member and only adding documentation, do not add any of the following labels:

• ~"frontend"
• ~"backend"
• ~"type::bug"
• ~"database"

These labels cause the MR to be added to code verification QA issues.

Reviewer's checklist

Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.

If you aren't sure which tech writer to ask, use roulette or ask in the #docs Slack channel.

• If the content requires it, ensure the information is reviewed by a subject matter expert.
• Technical writer review items:
  • Ensure docs metadata is present and up-to-date.
  • Ensure the appropriate labels are added to this MR.
  • Ensure a release milestone is set.
  • If relevant to this MR, ensure content topic type principles are in use, including:
    • The headings should be something you'd do a Google search for. Instead of Default behavior, say something like Default behavior when you close an issue.
    • The headings (other than the page title) should be active. Instead of Configuring GDK, say something like Configure GDK.
    • Any task steps should be written as a numbered list.
    • If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
• Review by assigned maintainer, who can always request/require the reviews above. Maintainer's review can occur before or after a technical writer review.

Thanks @eread, setting to merge.

What does this MR do?

For: #585946, let's provide some help with what we mean when we use the term "relation".

Result:

• https://docs.gitlab.com/upstream-review-mr-ee-226007/api/group_relations_export/
• https://docs.gitlab.com/upstream-review-mr-ee-226007/api/project_relations_export/
• https://docs.gitlab.com/upstream-review-mr-ee-226007/user/group/import/#estimating-migration-duration
• https://docs.gitlab.com/upstream-review-mr-ee-226007/user/group/import/troubleshooting/#source-instance

Author's checklist

• Optional. Consider taking the GitLab Technical Writing Fundamentals course.
• Follow the:
  • Documentation process.
  • Documentation guidelines.
  • Style Guide.
• If you're adding a new page, add the product availability details under the H1 topic title.
• If you are a GitLab team member, request a review based on:
  • The documentation page's metadata.
  • The associated Technical Writer.

If you are a GitLab team member and only adding documentation, do not add any of the following labels:

• ~"frontend"
• ~"backend"
• ~"type::bug"
• ~"database"

These labels cause the MR to be added to code verification QA issues.

Reviewer's checklist

Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.

If you aren't sure which tech writer to ask, use roulette or ask in the #docs Slack channel.

• If the content requires it, ensure the information is reviewed by a subject matter expert.
• Technical writer review items:
  • Ensure docs metadata is present and up-to-date.
  • Ensure the appropriate labels are added to this MR.
  • Ensure a release milestone is set.
  • If relevant to this MR, ensure content topic type principles are in use, including:
    • The headings should be something you'd do a Google search for. Instead of Default behavior, say something like Default behavior when you close an issue.
    • The headings (other than the page title) should be active. Instead of Configuring GDK, say something like Configure GDK.
    • Any task steps should be written as a numbered list.
    • If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
• Review by assigned maintainer, who can always request/require the reviews above. Maintainer's review can occur before or after a technical writer review.

Kati Paizee (8e5ac8c4) at 17 Mar 06:09

... and 1 more commit

Kati Paizee (dbecf790) at 17 Mar 06:09

What does this MR do and why?

Removes Beta status from Work Items documentation per the the following conversation:

#520452 (comment 3158586225)

Thanks @mmacfarlane! We had updated the history in one of the subheadings to say the feature was GA, but missed the beta status on the H1 heading. Approving and merging.

What does this MR do and why?

Removes Beta status from Work Items documentation per the the following conversation:

#520452 (comment 3158586225)