@ekigbo Here is the MR to add these guidelines to Pajamas: Add error handling cases (!5761).
This MR adds error handling guideline specific to the Dashboard panel (https://design.gitlab.com/components/dashboard-panel).
Closes #1889
This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.
~"component:*" label(s) if applicable.doc/publishing-packages.md.If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
@gitlab-com/gl-security/appsec
If this MR adds or modifies a component, take a few moments to review the following:
aria-label for icons that have meaning or perform actions.aria-expanded="false" to aria-expanded="true" when an accordion is expanded.Libor Vanc (02b3b70c) at 19 Mar 01:20
Add error handling cases
Libor Vanc (6e2280d3) at 19 Mar 00:58
This would open the dynamic panel with the error details. See Move dashboard panel errors to dynamic panel (gitlab-org/gitlab#523311).
@ekigbo Just a heads up. Since the app chrome has changed after this issue was initially opened, I updated the issue to now use the dynamic panel, instead of the drawer to hold the error details. See updated mockups in the the issue description. Also, moving this to workflowplanning breakdown.
/cc @blabuschagne
Link:
https://docs.gitlab.com/user/permissions/#application-security-group-permissions
This should link to the docs for the specific metric, for example: https://docs.gitlab.com/user/group/issues_analytics/
Should be displayed as an Empty state not and not an Error as suggested in the Pajamas guidelines.
Closing this issue since this will be addressed in UX: Define error handling and messaging for das... (gitlab-org/gitlab-services/design.gitlab.com#1889).
@rutshah @diegocapetown Thanks for the questions. Here is how I am thinking about this...
Explore->Analytics Dashboards-> CI/CD Analytics
The goal is that the dashboard will exist in one place.
Linking
The details of this are still TBD and we will continue to collaborate on this more once our teams gets closer to diving into this, but at a high level, I still see it working as you mentioned:
For Project level
What's the plan for the current dashboards under Analyze in this new design?
We have been in the process of migrating and consolidating the ones with the most usage out of the group/project hierarchy and deprecating the dashboards with low to no usage. See Group::Optimize Dashboard Feature Deprecations ... (gitlab-org#19129).
/cc @lfarina8 @blabuschagne feel free to add anything I may have missed.