Muhammad Daffa Dinaya (a093755c) at 20 Mar 16:29
Merge branch 'ashvins/upgrade-base-image-version' into 'main'
... and 80 more commits
fix(docker-network): cleanup network on failed inspect network
Signed-off-by: Muhammad Daffa Dinaya [email protected]
Close #39224
Muhammad Daffa Dinaya (49a1a5c4) at 19 Mar 15:37
fix(docker-network): cleanup network on failed inspect network
Muhammad Daffa Dinaya (74fae2a5) at 18 Mar 15:35
Merge branch 'vtak/update_json_library' into 'main'
... and 91 more commits
Muhammad Daffa Dinaya (fd75f027) at 21 Feb 07:56
Merge branch 'feature/build-pod-resource' into 'main'
... and 41 more commits
Muhammad Daffa Dinaya (e5e8d00a) at 16 Feb 15:42
Merge branch 'ajwalker/refactor-cache' into 'main'
... and 123 more commits
Muhammad Daffa Dinaya (53b3000e) at 17 Jan 08:01
Merge branch 'vtak/fix_pkcs7' into 'main'
... and 82 more commits
Muhammad Daffa Dinaya (17c92b34) at 14 Dec 10:33
Merge branch 'ajwalker/emulate-docker-links-func' into 'main'
... and 224 more commits
Muhammad Daffa Dinaya (8db2bf2d) at 14 Dec 10:33
feat: [WIP] proxy test
To upgrade to the supported client version, i think we need to resolve this #38784
Muhammad Daffa Dinaya (e63075a8) at 30 Oct 01:32
fix: [WIP] add mock on verb
Muhammad Daffa Dinaya (505b6f02) at 25 Oct 15:42
fix: merge http and error proxy test case
Muhammad Daffa Dinaya (2d3d2c33) at 18 Oct 08:50
chore: [WIP] refactor proxy request http
... and 39 more commits
Still, this is an improvement in my books, and we maybe merge some tests or do some refactoring when we look at the other tests in this package.
Hi, after checking on the other test. It seems there are overlapping testcase, e.g. TestProxyRequestHTTP's Returns error if the pod is not ready and TestProxyRequestError's Pod is not ready yet. I will also merge these test case so we dont need rework on the future.
You can either setup the fake client without any pod (or at least not the pod the production code will ask for), or inject this error with a reactor.
Got it, i will try to implement fakeclient first.
This can happen when e.g. the executor is able to create the pod initially, but then something happens on the cluster and the pod vanishes, or changes state, ...
Thanks for the answer
Thanks for your code suggestion and the review! I have read the thread and replied with several questions
cmiiw, if i want to implement this, it means i need to set the NewSimpleClientset with different name from the expected pod name?
Also, may i know other example of the drift between the executor cache and the k8s? Is it only applied on the proxy test case or we also need to check on the other part?
I will add containerReady: true to ensure exhaustive test coverage
For this test case will drop the podStatus -> podPhase. Also i will drop unnecessary attribute that is not related on the testcase
@hoegaarden I have submitted the MR for TestProxyRequestError and plan to continue with TestExec, following the logic in TestAttach (!5838 (merged)).
Please let me know if there are other parts that should be prioritized.