Next follow up: !95 (merged)

• Update all minor package versions
• Update major versions of only better-sqlite3, dompurify and webpack-cli
• Extend README with nvm, node version manager. Plus format markdown file correctly.
• Update default docker image in CI/CD to Node LTS version (alpine)
• Version bump to v0.1.0 package version after 6 years ;)

Follow-up from: !94

Melroy van den Berg (21b9d119) at 28 Feb 15:24

... and 2 more commits

Melroy van den Berg (1be5272c) at 28 Feb 15:10

... and 1 more commit

Does this might be related to: #590905 ?

I can confirm this issue! It used to be fine before the upgrade.. But now I get unverified commits:

It's complaining about unsupported signature? But I use the same GPG signature as well, its still a valid sig. And NOT expired.

Signature is added in my GitLab profile settings as my trusted GPG signature.

@ajwalker Thanks for your heads up!

That makes sense, I will try to keep icc to false ideally. I disabled that for security reasons. And instead try to set FF_NETWORK_PER_BUILD.

I do use custom docker networks for my other deployments in Docker as well. I notice Gitlab runner has an option for network_mode, but that doesn't seems to be the right one (you might want to update that documentation page, since its misleading saying that network_mode can be used to set a custom network, which might imply custom docker network).

Anyhow, I will try to follow the new documentation about this:

    [runners.feature_flags]
      FF_NETWORK_PER_BUILD = true

And will let you know!

EDIT: Feature flag worked here.

Melroy van den Berg (95330230) at 26 Feb 16:44

we could also rename the stage, to like test instead of lint. which is more common name, and a default in GitLab. If you wish.

so I started with fix fixing the linting / prettier.. before I do anything else, see MR: !94 (merged)

• Before we upgrading anything else, lets start with formatting using prettier first (and make it mandatory in our GitLab CI job)
  • Updated prettier version
  • Add -y (yes) flag
  • Extended .gitlab-ci.yml file
  • Add .prettierignore file and exclude the static directory, which contains js/cdn directory we do not care about. Do we want to format maybe static/js/create.js?
  • Add dedicated "check" scripts in package.json for both eslint as well as prettier (which is only checking, not fixing)
    • This is a best practice, rather than trying to run scripts from node_modules directory
  • Finally, I ran prettier fix of course + format gitlab yaml file

No production changes, only formatting.

Rationale: Enforcing formatting tool like prettier helps to write the same kind of code style. Making it easier to work together with a large team, especially in case of merge conflicts or working with diffs. Which might help now. especially since we would like to bump up all npm deps packages, npm major releases, Node.js version, etc.

First step in: #112

Melroy van den Berg (c499f575) at 22 Feb 14:48

Yea upgrading from node v20 with so many out dated packages for so long won't be easy..

It might a good idea to break down the work in smaller MRs to avoid regression and easier for reviewing as well.

EDIT: I also already see that prettier wasn't run for quite a while as well.

EDIT EDIT: I also notice many deprecated warnings as well:

npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated @humanwhocodes/[email protected]: Use @eslint/config-array instead
npm warn deprecated [email protected]: Old versions of glob are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting [email protected]
npm warn deprecated @humanwhocodes/[email protected]: Use @eslint/object-schema instead
npm warn deprecated [email protected]: Multer 1.x is impacted by a number of vulnerabilities, which have been patched in 2.x. You should upgrade to the latest 2.x version.
npm warn deprecated [email protected]: No longer maintained. Please contact the author of the relevant native addon; alternatives are available.
npm warn deprecated [email protected]: electrum cash packages have been moved to the @electrum-cash/* namespace.
npm warn deprecated [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.

ok, thank you for your fast confirmation, issue created: #553