Jonathan Silverblood activity https://gitlab.com/monsterbitar 2026-03-17T07:19:41Z tag:gitlab.com,2026-03-17:5211272483 Jonathan Silverblood commented on issue #49 at GeneralProtocols / XO / engine 2026-03-17T07:19:41Z monsterbitar Jonathan Silverblood

it seems reasonable to me that commits with non-authorized data would not be shared to other role-holders before first being returned to the party that can do the authorization.

Even if it does, that would still be fine as blame can clearly be laid at the party claiming a role and then not signinf off on the data, either because:

  1. if you disregard the data then there is unfullfilled requirements, or
  2. if you consider the data then there is a party that hasn't yet signed

So it comes down to the question of "did entity X call signInivitation()?"

If they did, but didn't sign the other data, then that data is to be disregarded (treat it as it simply wasn't there). If they didn't, then treat treat the invitation as non-complete as a role requirement still remains to be fullfilled.

tag:gitlab.com,2026-03-16:5207634809 Jonathan Silverblood approved merge request !4: Add pipeline, fix audit and update project configs at GeneralProtocols / XO / templates 2026-03-16T10:53:34Z monsterbitar Jonathan Silverblood
tag:gitlab.com,2026-03-16:5206812865 Jonathan Silverblood approved merge request !17: Add role view properties to outputs at GeneralProtocols / XO / types 2026-03-16T07:37:43Z monsterbitar Jonathan Silverblood
tag:gitlab.com,2026-03-16:5206809144 Jonathan Silverblood commented on merge request !4 at GeneralProtocols / XO / templates 2026-03-16T07:36:33Z monsterbitar Jonathan Silverblood

approved now so that I can see in the log that I have reviewed and approved this earlier and can re-review only the changes.

tag:gitlab.com,2026-03-16:5206808255 Jonathan Silverblood approved merge request !4: Add pipeline, fix audit and update project configs at GeneralProtocols / XO / templates 2026-03-16T07:36:14Z monsterbitar Jonathan Silverblood
tag:gitlab.com,2026-03-16:5206802809 Jonathan Silverblood commented on merge request !4 at GeneralProtocols / XO / state 2026-03-16T07:34:18Z monsterbitar Jonathan Silverblood

I assume these either are no longer needed, or have been moved elsewhere prior to this MR.

tag:gitlab.com,2026-03-16:5206797472 Jonathan Silverblood commented on merge request !4 at GeneralProtocols / XO / state 2026-03-16T07:32:38Z monsterbitar Jonathan Silverblood

this creates two storage adapters.

I assume it's better to do "const storageAdapterPromise = createStorageAdapter(...);

then await expect(storageAdapterPromise...

tag:gitlab.com,2026-03-16:5206789848 Jonathan Silverblood commented on merge request !4 at GeneralProtocols / XO / state 2026-03-16T07:29:49Z monsterbitar Jonathan Silverblood

./ doesn't seem like a temp directory.

tag:gitlab.com,2026-03-16:5206785266 Jonathan Silverblood commented on merge request !4 at GeneralProtocols / XO / state 2026-03-16T07:28:07Z monsterbitar Jonathan Silverblood

maximum of 1 here, but checks in this MR compare against both >1 and >2

tag:gitlab.com,2026-03-15:5204941699 Jonathan Silverblood approved merge request !2: Fix multiple reported issues and more that were not reported at GeneralProtocols / XO / templates 2026-03-15T07:09:10Z monsterbitar Jonathan Silverblood

Fixes the follwing issues:

  • #2
  • #8
    • Populated the sent/send information
    • Add role based descriptions for other non-receive transactions
  • #12
    • Correct tenses
    • Spelling Mistake
    • Role based description in output
  • #18

And other non-reported issues

tag:gitlab.com,2026-03-15:5204915794 Jonathan Silverblood commented on merge request !2 at GeneralProtocols / XO / templates 2026-03-15T06:35:38Z monsterbitar Jonathan Silverblood

Minor descript changes pending, this all looks good to me.

tag:gitlab.com,2026-03-15:5204913440 Jonathan Silverblood commented on merge request !2 at GeneralProtocols / XO / templates 2026-03-15T06:31:39Z monsterbitar Jonathan Silverblood

same here, could drop "to the receiver."

tag:gitlab.com,2026-03-15:5204913346 Jonathan Silverblood commented on merge request !2 at GeneralProtocols / XO / templates 2026-03-15T06:31:30Z monsterbitar Jonathan Silverblood

same here, could drop "to the receiver."

tag:gitlab.com,2026-03-15:5204913120 Jonathan Silverblood commented on merge request !2 at GeneralProtocols / XO / templates 2026-03-15T06:31:07Z monsterbitar Jonathan Silverblood

same here, could drop "to the receiver"

tag:gitlab.com,2026-03-15:5204912885 Jonathan Silverblood commented on merge request !2 at GeneralProtocols / XO / templates 2026-03-15T06:30:45Z monsterbitar Jonathan Silverblood

same here, could drop "to the receiver"

tag:gitlab.com,2026-03-15:5204912469 Jonathan Silverblood commented on merge request !2 at GeneralProtocols / XO / templates 2026-03-15T06:30:08Z monsterbitar Jonathan Silverblood

similar here, could drop the "to the receiver" (where else would it be sent?)

tag:gitlab.com,2026-03-15:5204912173 Jonathan Silverblood commented on merge request !2 at GeneralProtocols / XO / templates 2026-03-15T06:29:41Z monsterbitar Jonathan Silverblood

This could be "Sent $()" for simplcity.

the "to the receiver" doesn't really add much value, I think.

tag:gitlab.com,2026-03-14:5204384412 Jonathan Silverblood approved merge request !4: Add pipeline, fix audit and update project configs at GeneralProtocols / XO / templates 2026-03-14T19:38:52Z monsterbitar Jonathan Silverblood
tag:gitlab.com,2026-03-14:5204384103 Jonathan Silverblood approved merge request !6: Add pipeline, fix npm audit, update configs at GeneralProtocols / XO / primitives 2026-03-14T19:38:20Z monsterbitar Jonathan Silverblood