/chatops run feature set ci_stop_writing_to_pipeline_variables 75 --actors

Going ahead with 50%:

/chatops run feature set ci_stop_writing_to_pipeline_variables 50 --actors

/chatops run feature set ci_stop_writing_to_pipeline_variables 30 --actors

What does this MR do and why?

Freezes factory-created objects in spec/models/ci/runner_spec.rb by adding freeze: true to let_it_be declarations throughout the spec file.

This is a test optimization that:

• Replaces let_it_be (without freeze) and let_it_be_with_reload with let_it_be(:name, freeze: true) where the test does not mutate the object
• Replaces let_it_be_with_refind with let_it_be(:name, freeze: true) where refind was unnecessary
• Converts a few cases to let_it_be_with_refind where the object is actually mutated in before blocks
• Inlines a shared example (group or project runner initializing organization_id) that was only used twice, simplifying the test structure
• Hoists shared admin and user2 let_it_be declarations to a higher scope to avoid duplication across with_creator_id and created_by_admins describe blocks
• Reuses the existing other_organization let_it_be instead of creating a duplicate other_org in the assignable_for context
• Consolidates runner attribute setup (e.g., token_expires_at) into the factory call instead of a separate before block

Frozen objects raise FrozenError if a test accidentally modifies them, catching unintended side effects between examples. This also improves test performance by avoiding unnecessary database reloads.

References

• #591183

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Thanks @pedropombeiro, LGTM 🚀

@arfedoro nice cleanup 💯! LGTM for test ✅

What does this MR do?

Removes the security_policies_split_view feature flag from backend code and deletes the flag definition file, completing the feature flag cleanup.

After this MR, the split view (advanced editor toggle) is always available — gated only by the user preference (policy_advanced_editor). No feature flag check is needed.

Related to #593378

Note: This MR should be merged after !227098 (frontend cleanup).

Changes

Source files (4 files)

File	Change
groups/security/policies_controller.rb	Removed push_frontend_feature_flag(:security_policies_split_view, group)
projects/security/policies_controller.rb	Removed push_frontend_feature_flag(:security_policies_split_view, project.group)
security_orchestration_helper.rb	Removed Feature.enabled? check from policy_editor_enabled?
security_policies_split_view.yml	Deleted

Test files (6 files)

• Removed stub_feature_flags(security_policies_split_view: ...) from helper spec and all 5 feature specs

MR acceptance checklist

• RSpec helper spec passes (56 examples, 0 failures)
• Rubocop passes (0 offenses)
• No remaining references to security_policies_split_view in the codebase
• Feature flag YAML definition deleted

Going ahead with 10%:

/chatops run feature set ci_stop_writing_to_pipeline_variables 10 --actors

Starting incremental roll out on Production:

/chatops run feature set ci_stop_writing_to_pipeline_variables 1 --actors

Deployed to specific projects on production environment:

/chatops run feature set --project=gitlab-org/gitlab,gitlab-org/gitlab-foss,gitlab-com/www-gitlab-com ci_stop_writing_to_pipeline_variables true

Hi @reprazent could you please help with the final backend review on this? Thanks!

What does this MR do and why?

Fixes undercoverage

References

Screenshots or screen recordings

Before	After

How to set up and validate locally

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #592774

Thanks @fdegier and @abime LGTM ✅

Enabling globally for non-prod environments:

/chatops run feature set stop_writing_to_ci_pipeline_variables true --dev --pre --staging --staging-ref

Deployed to non-prod environments:

/chatops run feature set stop_writing_to_ci_pipeline_variables 50 --actors --dev --pre --staging --staging-ref

The MR has been merged now, closing the issue!

@lma-git Thanks for your review and approval. Really appreciate

Marking the status to green now (from yellow earlier) as we have received the final approval and auto-merge has been enabled for the MR.