Naman Jagdish Gala activity https://gitlab.com/ngala 2026-03-17T11:38:51Z tag:gitlab.com,2026-03-17:5212403456 Naman Jagdish Gala approved merge request !1253: Update module gitlab.com/gitlab-org/labkit/v2 to v2.0.0-20260316151747-255e9e7abf22 at GitLab.org / gitlab-p... 2026-03-17T11:38:51Z ngala Naman Jagdish Gala

This MR contains the following updates:

Package Type Update Change
gitlab.com/gitlab-org/labkit/v2 require patch v2.0.0-20260313093530-689dca33010c -> v2.0.0-20260316151747-255e9e7abf22

MR created with the help of gitlab-org/frontend/renovate-gitlab-bot


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this MR and you won't be reminded about this update again.


  • If you want to rebase/retry this MR, check this box

This MR has been generated by Renovate Bot.

tag:gitlab.com,2026-03-17:5212162701 Naman Jagdish Gala commented on issue #584281 at GitLab.org / GitLab 2026-03-17T10:45:15Z ngala Naman Jagdish Gala

@igor.drozdov Thank you so much for taking time to sync with me on my local issue.

@nateweinshenker, the MCP tools were getting registered, but the main problem was that only gitlab_search was being returned, which we weren't looking at. We also checked out your MRs to verify whether we could access the other MCP tools and add them in the new agents UI. I think it's still in development, as there are some console errors in the UI when accessing existing agents.

Thank you everyone for your support.

tag:gitlab.com,2026-03-17:5211680773 Naman Jagdish Gala deleted project branch ef-migrate-to-v2-labkit at GitLab.org / gitlab-pages 2026-03-17T09:05:38Z ngala Naman Jagdish Gala

Naman Jagdish Gala (bccba630) at 17 Mar 09:05

tag:gitlab.com,2026-03-17:5211680275 Naman Jagdish Gala pushed to project branch master at GitLab.org / gitlab-pages 2026-03-17T09:05:31Z ngala Naman Jagdish Gala

Naman Jagdish Gala (7e4aff87) at 17 Mar 09:05

Merge branch 'ef-migrate-to-v2-labkit' into 'master'

... and 1 more commit

tag:gitlab.com,2026-03-17:5211680254 Naman Jagdish Gala accepted merge request !1241: Migrate all logging to labkit v2/log (slog-based API) at GitLab.org / gitlab-pages 2026-03-17T09:05:31Z ngala Naman Jagdish Gala

What does this MR do?

Migrates all structured logging in gitlab-pages from Logrus (github.com/sirupsen/logrus) and labkit v1 (gitlab.com/gitlab-org/labkit/log) to the labkit v2 slog-based API (gitlab.com/gitlab-org/labkit/v2/log).

Why

LabKit v2 standardises on Go's log/slog for structured logging across all GitLab Go services. This migration:

  • Removes the Logrus and labkit v1 log dependencies from the logging path
  • Aligns gitlab-pages with the LabKit v2 logging standard adopted by gitlab-shell and the go-service-template
  • Enables future use of labkit v2 typed log helpers for consistent field names across services

Changes (32 files)

Core logging (internal/logging/logging.go)

  • Replaced logrus.Entry-based LogRequest with a context-enriching function that returns context.Context with correlation_id, host, and path fields via logv2.WithFields
  • Replaced labkit v1 log.AccessLogger middleware with a self-contained BasicAccessLogger using a responseRecorder wrapper that captures status code and response size
  • Introduced var Logger = logv2.New() as the global application logger, reconfigured by ConfigureLogging
  • Added LevelTrace constant (slog.LevelDebug - 4) for verbose diagnostic logging

All call sites (20+ files)

  • Replaced logging.LogRequest(r).WithField(...).Info(...) pattern with logging.Logger.InfoContext(logging.LogRequest(r), ..., key, value) throughout:
    • internal/auth/auth.go and internal/auth/session.go (OAuth flow logging)
    • internal/acme/acme.go (ACME challenge redirects)
    • internal/artifact/artifact.go (artifact proxy requests)
    • internal/domain/domain.go (domain resolution errors)
    • internal/handlers/ (authentication and artifact handlers)
    • internal/httperrors/httperrors.go (500 error logging)
    • internal/httprange/http_reader.go (range request errors)
    • internal/httptransport/metered_round_tripper.go (trace-level response logging)
    • internal/namespaceinpath/middleware.go (namespace URL rewriting)
    • internal/primarydomain/middleware.go (primary domain redirects)
    • internal/ratelimiter/middleware.go and tls.go (rate limit logging)
  • Replaced logrus.Fields{} with inline key-value pairs
  • Replaced .WithError(err) with "error", err attribute

Slow-log middleware (internal/logging/slowlogs/)

  • Changed LoggerFunc signature from func(*http.Request) *logrus.Entry to func(*http.Request) context.Context
  • Updated tests to use logtest.LogRecorder instead of testlog.Hook

Tests

  • Migrated all test logging assertions from testlog.Hook (Logrus) to logtest.LogRecorder (labkit v2)
  • Updated internal/ratelimiter/middleware_test.go and tls_test.go to swap the global Logger for test isolation

CI

  • Pinned Go test matrix to 1.25 (removed 1.24)
  • Set allow_failure: true on code_quality job pending golangci-lint v2 upgrade

What is NOT in this MR

  • Removal of Logrus from go.mod (other packages may still import it transitively)
  • Migration of labkit v1 correlation or tracing middleware (separate effort)
  • golangci-lint v2 upgrade (separate MR)

Checklist

tag:gitlab.com,2026-03-17:5211290573 Naman Jagdish Gala commented on issue #21559 at GitLab.com / GitLab Infrastructure Team / Production 2026-03-17T07:24:28Z ngala Naman Jagdish Gala

Initiated the revert: gitlab-com/gl-infra/k8s-workloads/gitlab-com!5278

tag:gitlab.com,2026-03-17:5211285284 Naman Jagdish Gala commented on merge request !5278 at GitLab.com / GitLab Infrastructure Team / Kubernetes Workloads / GitLab.com 2026-03-17T07:23:08Z ngala Naman Jagdish Gala

@vglafirov Can you please review this small change. Thank you.

tag:gitlab.com,2026-03-17:5211265588 Naman Jagdish Gala opened merge request !5278: Revert "gprd: increase gitlab-pages authCookieSessionTimeout to 60m" at GitLab.com / GitLab Infrastructure Tea... 2026-03-17T07:17:08Z ngala Naman Jagdish Gala

What does this MR do?

This reverts the change from !5174, which increased the gitlab-pages authCookieSessionTimeout to 60m in gprd.

The authCookieSessionTimeout line is removed, restoring the default behavior.

gitlab-com/gl-infra/production#21559: We are investigating if this revert can fix the incident.

tag:gitlab.com,2026-03-17:5211262487 Naman Jagdish Gala pushed new project branch duo-edit-20260317-071555 at GitLab.com / GitLab Infrastructure Team / Kubernetes Workloads / GitLab.com 2026-03-17T07:16:00Z ngala Naman Jagdish Gala

Naman Jagdish Gala (4729846c) at 17 Mar 07:16

Revert "gprd: increase gitlab-pages authCookieSessionTimeout to 60m"

tag:gitlab.com,2026-03-17:5211054578 Naman Jagdish Gala commented on epic #21188 at GitLab.org 2026-03-17T05:52:37Z ngala Naman Jagdish Gala

Please ensure that any updates to GraphQL filters are reflected in the saved view MCP tool.

/cc @mmacfarlane

tag:gitlab.com,2026-03-17:5211021861 Naman Jagdish Gala commented on merge request !1241 at GitLab.org / gitlab-pages 2026-03-17T05:35:44Z ngala Naman Jagdish Gala

Created a follow up issue: #1180

tag:gitlab.com,2026-03-17:5211019307 Naman Jagdish Gala opened issue #1180: Upgrade golangci-lint to v2 at GitLab.org / gitlab-pages 2026-03-17T05:34:05Z ngala Naman Jagdish Gala tag:gitlab.com,2026-03-17:5211006895 Naman Jagdish Gala commented on merge request !1241 at GitLab.org / gitlab-pages 2026-03-17T05:26:39Z ngala Naman Jagdish Gala

@e_forbes Based on the conversation, we can move ahead with the setting up minimum go version to 1.25.

GitLab 18.7.6, 18.8.6, and 18.9.2 was released with Go 1.25.7.

Overall change LGTM. Thank you.

tag:gitlab.com,2026-03-17:5211006808 Naman Jagdish Gala approved merge request !1241: Migrate all logging to labkit v2/log (slog-based API) at GitLab.org / gitlab-pages 2026-03-17T05:26:36Z ngala Naman Jagdish Gala

What does this MR do?

Migrates all structured logging in gitlab-pages from Logrus (github.com/sirupsen/logrus) and labkit v1 (gitlab.com/gitlab-org/labkit/log) to the labkit v2 slog-based API (gitlab.com/gitlab-org/labkit/v2/log).

Why

LabKit v2 standardises on Go's log/slog for structured logging across all GitLab Go services. This migration:

  • Removes the Logrus and labkit v1 log dependencies from the logging path
  • Aligns gitlab-pages with the LabKit v2 logging standard adopted by gitlab-shell and the go-service-template
  • Enables future use of labkit v2 typed log helpers for consistent field names across services

Changes (32 files)

Core logging (internal/logging/logging.go)

  • Replaced logrus.Entry-based LogRequest with a context-enriching function that returns context.Context with correlation_id, host, and path fields via logv2.WithFields
  • Replaced labkit v1 log.AccessLogger middleware with a self-contained BasicAccessLogger using a responseRecorder wrapper that captures status code and response size
  • Introduced var Logger = logv2.New() as the global application logger, reconfigured by ConfigureLogging
  • Added LevelTrace constant (slog.LevelDebug - 4) for verbose diagnostic logging

All call sites (20+ files)

  • Replaced logging.LogRequest(r).WithField(...).Info(...) pattern with logging.Logger.InfoContext(logging.LogRequest(r), ..., key, value) throughout:
    • internal/auth/auth.go and internal/auth/session.go (OAuth flow logging)
    • internal/acme/acme.go (ACME challenge redirects)
    • internal/artifact/artifact.go (artifact proxy requests)
    • internal/domain/domain.go (domain resolution errors)
    • internal/handlers/ (authentication and artifact handlers)
    • internal/httperrors/httperrors.go (500 error logging)
    • internal/httprange/http_reader.go (range request errors)
    • internal/httptransport/metered_round_tripper.go (trace-level response logging)
    • internal/namespaceinpath/middleware.go (namespace URL rewriting)
    • internal/primarydomain/middleware.go (primary domain redirects)
    • internal/ratelimiter/middleware.go and tls.go (rate limit logging)
  • Replaced logrus.Fields{} with inline key-value pairs
  • Replaced .WithError(err) with "error", err attribute

Slow-log middleware (internal/logging/slowlogs/)

  • Changed LoggerFunc signature from func(*http.Request) *logrus.Entry to func(*http.Request) context.Context
  • Updated tests to use logtest.LogRecorder instead of testlog.Hook

Tests

  • Migrated all test logging assertions from testlog.Hook (Logrus) to logtest.LogRecorder (labkit v2)
  • Updated internal/ratelimiter/middleware_test.go and tls_test.go to swap the global Logger for test isolation

CI

  • Pinned Go test matrix to 1.25 (removed 1.24)
  • Set allow_failure: true on code_quality job pending golangci-lint v2 upgrade

What is NOT in this MR

  • Removal of Logrus from go.mod (other packages may still import it transitively)
  • Migration of labkit v1 correlation or tracing middleware (separate effort)
  • golangci-lint v2 upgrade (separate MR)

Checklist

tag:gitlab.com,2026-03-17:5211004542 Naman Jagdish Gala commented on merge request !1241 at GitLab.org / gitlab-pages 2026-03-17T05:25:16Z ngala Naman Jagdish Gala

Can we create an issue to track golangci-lint v2 upgrade. Thank you.

tag:gitlab.com,2026-03-16:5209218710 Naman Jagdish Gala commented on merge request !227366 at GitLab.org / GitLab 2026-03-16T16:31:55Z ngala Naman Jagdish Gala

@JonstonChan backend LGTM. Thank you.

@eduardobonet Can you please perform backend maintainer review. Thank you.

tag:gitlab.com,2026-03-16:5209217366 Naman Jagdish Gala approved merge request !227366: Fix non-auto-correctable Naming/HeredocDelimiterNaming offenses at GitLab.org / GitLab 2026-03-16T16:31:36Z ngala Naman Jagdish Gala

What does this MR do and why?

Fixes non-auto-correctable Naming/HeredocDelimiterNaming offenses

References

Screenshots or screen recordings

Before After

How to set up and validate locally

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #589138

tag:gitlab.com,2026-03-16:5209173566 Naman Jagdish Gala commented on issue #21559 at GitLab.com / GitLab Infrastructure Team / Production 2026-03-16T16:20:36Z ngala Naman Jagdish Gala

5th March: There hasn't been any change in Pages on this date.

2nd March: The only change that occurred is gitlab-com/gl-infra/k8s-workloads/gitlab-com!5174 (merged). We can revert it to verify whether that caused the issue.

/cc @kivikakk