I monitored this again yesterday and noticed there wasn't much difference. I wonder @michold did we ever consider manually flushing the Snowplow emitter for the ruby sdk?
@michold this MR is in draft state but would like to get your review and thoughts here. Passing in Hash object of events here in sidekiq could impact performance, do you know if it is possible to retrieve events with an id.
Nwanna Isong (b8320361) at 19 Mar 07:33
Update spec files
This class is inheriting from SnowplowTracker::Emitter and not the SnowplowTracker::AsyncEmitter because the SnowplowTracker::AsyncEmitter spins up threads that we do not need since we are using sidekiq to handle these requests.
Nwanna Isong (b75dd364) at 19 Mar 07:11
Update spec files
Thanks @jtucker_gl I added some comments
Hi @jtucker_gl thanks for this MR, I left some suggestions.
let_it_be(:group) { create(:group) } let_it_be(:group) { create(:group) } let_it_be(:project) { create(:project) } let_it_be(:group) { create(:group) }milestone: '18.11'