Julian Stirling (ff5eb220) at 17 Mar 23:34

Julian Stirling (b0d1e262) at 17 Mar 23:34

... and 2 more commits

Closes one of two issues related to #728

This MR contains the following

• Updates manually running server docs with working command

Merge checklist:

• All new/changed functions have up to date typehints and docstrings
• Any UI updates have a before and after screenshot in the MR description
• Unit testing of new functionality has similar or better coverage than similar existing code
• This code has been tested on a microscope
  • Webapp has been recompiled, with aesthetic changes checked in light and dark mode (if changed)
  • With updated settings JSON (if changed)
  • SmartScan and live stitching work

Julian Stirling (fbcd7eee) at 17 Mar 23:33

I have a touchscreen attached to the microscope. I'm unable to skip the initial calibration steps. I have the camera setup, but the stage-camera mapping isn't done yet. The only option I have is to click "next". On MobaXterm / desktop, pressing "escape" turns off this dialog box and allows me to use the microscope.

What's needed is either a button that cancels / "remind me later", or clicking / pressing the background should close that prompt, maybe with a popup saying "you can restart this setup in Settings" in case someone clicks it away accidentally?

Feature request

Summary

Can only escape calibration wizard by hitting Esc. Would be good to add a button to close from any frame

Julian Stirling (0b3ce54a) at 17 Mar 23:33

... and 2 more commits

Closes #677 openflexure-connect#40

This MR contains the following

• Close button in calibration modal
• Confirmation before closing with suggestion from @apopanda
• Centre CSM button
• Change "No CSM available" to "No CSM data available"

This takes the low hanging fruit out of !481

This button is now centred and the text doesn't suggest CSM isn't available

Merge checklist:

• All new/changed functions have up to date typehints and docstrings
• Any UI updates have a before and after screenshot in the MR description
• Unit testing of new functionality has similar or better coverage than similar existing code
• This code has been tested on a microscope
  • Webapp has been recompiled, with aesthetic changes checked in light and dark mode (if changed)
  • With updated settings JSON (if changed)
  • SmartScan and live stitching work

Julian Stirling (8ee5609d) at 17 Mar 23:26

Thanks for the changes @jaknapper. This works as expected. I have also checked that with escape, I can then tab to the OK and press enter. So keyboard navigation works.

At some point we probably want keyboard navigation to be more firmly on our accessibility radar. But I have no idea what the expected behaviour here is.

Closes #677 openflexure-connect#40

This MR contains the following

• Close button in calibration modal
• Confirmation before closing with suggestion from @apopanda
• Centre CSM button
• Change "No CSM available" to "No CSM data available"

This takes the low hanging fruit out of !481

This button is now centred and the text doesn't suggest CSM isn't available

Merge checklist:

• All new/changed functions have up to date typehints and docstrings
• Any UI updates have a before and after screenshot in the MR description
• Unit testing of new functionality has similar or better coverage than similar existing code
• This code has been tested on a microscope
  • Webapp has been recompiled, with aesthetic changes checked in light and dark mode (if changed)
  • With updated settings JSON (if changed)
  • SmartScan and live stitching work

Closes one of two issues related to #728

This MR contains the following

• Updates manually running server docs with working command

Merge checklist:

• All new/changed functions have up to date typehints and docstrings
• Any UI updates have a before and after screenshot in the MR description
• Unit testing of new functionality has similar or better coverage than similar existing code
• This code has been tested on a microscope
  • Webapp has been recompiled, with aesthetic changes checked in light and dark mode (if changed)
  • With updated settings JSON (if changed)
  • SmartScan and live stitching work

Joe Knapper (abf3edef) at 17 Mar 19:18

Joe Knapper (fbcd7eee) at 17 Mar 19:11

Closes one of two issues related to #728

This MR contains the following

• Updates manually running server docs with working command

Merge checklist:

• All new/changed functions have up to date typehints and docstrings
• Any UI updates have a before and after screenshot in the MR description
• Unit testing of new functionality has similar or better coverage than similar existing code
• This code has been tested on a microscope
  • Webapp has been recompiled, with aesthetic changes checked in light and dark mode (if changed)
  • With updated settings JSON (if changed)
  • SmartScan and live stitching work

Julian Stirling (f9fbdafe) at 17 Mar 18:49

... and 1 more commit

This is based upon !24 which should be merged first

• Fix issue with shellcheck script where errors ignored in Python script are counted but not reported.
• Fix remaining shellcheck errors
• Stop allowing failure on CI

Julian Stirling (512a8af0) at 17 Mar 18:45

... and 4 more commits

Joe Knapper (dbc01c80) at 17 Mar 18:25

... and 15 more commits