Our code is 50 / 50 between enums and non-enums. Will get this sorted as it is broken at present.

I've been trying to stay a way from storing Qt enums in the config, I'd much rather do a conversion in code. I ran into this recently when I was looking at why another checkbox was not affecting a feature. Being more explicit about this will make future stuff work better.

crashes on macOS Description

OpenLP when using the remote web interface to search for Bible verses with invalid or unrecognized references.

Environment

• OpenLP Version: 3.1.7
• Operating System: macOS

Steps to Reproduce

1. Start OpenLP with web server enabled
2. Open the remote web interface
3. Search for an invalid Bible reference
4. Application crashes

Expected Behavior

Application should handle the error gracefully without crashing.

Actual Behavior

Application crashes with SIGABRT in Thread 32. The crash occurs because critical_error_message_box() is called from the HTTP server's background thread. On macOS, AppKit does not allow UI operations from non-main threads.

Suggested Fix

In openlp/plugins/bibles/lib/db.py, add a thread check:

if QtCore.QThread.currentThread() == QtCore.QCoreApplication.instance().thread(): critical_error_message_box(...) else: log.error('Bible search error in background thread...')

Test Results

• Invalid search from remote (macOS): CRASH -> Error logged, app continues
• Invalid search from main UI: Dialog shown (unchanged)
• Valid search: Works (unchanged)

Fix available at: https://github.com/jonatse/openLPfixesjonatse

That's also what I understood from your docs, but it doesn't succeed at that unfortunately.

The first two are not found:

Updating and loading repositories: Fedora 43 - x86_64 - Updates 100% | 216.8 KiB/s | 17.3 KiB | 00m00s Repositories loaded. Failed to resolve the transaction: No match for argument: libicu-dev No match for argument: python3-icu Package "pkgconf-pkg-config-2.3.0-3.fc43.x86_64" is already installed. You can try to add to command line: --skip-unavailable to skip unavailable packages

Are there repos to add first maybe?

Hum, that is what hatch is meant to do. You should not need to understand how to compile icu it just does it for you.

Do you have sudo libicu-dev python3-icu pkg-config installed outside the hatch environment?

Have a google and from experence,icu is a pain to compile.

Thanks @trb143 for responding :)

I've got that one installed, but cannot get icu to work:

$ pkg-config --cflags --libs icu-i18n Package icu-i18n was not found in the pkg-config search path. Perhaps you should add the directory containing `icu-i18n.pc' to the PKG_CONFIG_PATH environment variable Package 'icu-i18n' not found

Do you know how to install that? There is no simple way laid out for Fedora it seems.