@jivanvl We have our BE/Test approval now! Would you mind re-approving and possibly setting auto-merge? Thanks 🙇

Payton Burdette (28809a98) at 16 Mar 14:24

@vburton could you review the spec changes here please?

Hey @jivanvl do you by chance have time to review this bug fix for #589262 ?

Payton Burdette (18e61240) at 13 Mar 14:16

Payton Burdette (fe3ac381) at 13 Mar 13:56

Payton Burdette (c933625b) at 12 Mar 21:47

What does this MR do and why?

Fix pipeline secondary link

Fixes issue where schedule link was not showing up due to missing data in GraphQL.

Changelog: fixed

References

Screenshots or screen recordings

Before	After

How to set up and validate locally

1. Visit Build > Pipelines
2. Trigger a scheduled pipeline
3. Ensure the schedule description shows up for secondary link and is routed correctly

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #589262

Payton Burdette (4b8006e1) at 12 Mar 21:31

I think this is ready to go now @hfyngvason WDYT?

Payton Burdette (2a9e8d78) at 11 Mar 20:09

What does this MR do and why?

NOTE: This is just targeting .com, SM is here !225789

Add trial expired empty state for GitLab Duo Agent Platform (.com)

Track essential interactions to enable reporting on conversion funnel:

• User views expired trial promo in AI panel
• User clicks "Upgrade to Premium" button
• User clicks "Learn more" button

References

Screenshots or screen recordings

How to set up and validate locally

bin/rails c

org = Organizations::Organization.default_organization

group = Group.find_or_create_by!(path: "dap-trial-expired-test") do |g|
  g.name = "DAP Trial Expired Test"
  g.organization = org
  g.visibility_level = Gitlab::VisibilityLevel::PRIVATE
end

sub = group.gitlab_subscription || group.create_gitlab_subscription!(seats: 1, start_date: 60.days.ago.to_date)
sub.update_columns(
  trial: false,
  trial_starts_on: 60.days.ago.to_date,
  trial_ends_on: 1.day.ago.to_date,
  hosted_plan_id: nil
)

GitlabSubscriptions::AddOnPurchase.where(namespace: group).destroy_all

test_user = User.find_by(username: "trial-expired-tester")
unless test_user
  result = Users::CreateService.new(nil, {
    username: "trial-expired-tester",
    email: "[email protected]",
    name: "Trial Expired Tester",
    password: "Tr1alExp1red_Test3r!",
    skip_confirmation: true,
    organization_id: org.id
  }).execute
  test_user = result[:user]
end

group.add_owner(test_user) unless group.member?(test_user)

unless Project.find_by(path: "test-project", namespace: group)
  Projects::CreateService.new(test_user, {
    name: "Test Project",
    path: "test-project",
    namespace_id: group.id,
    visibility_level: Gitlab::VisibilityLevel::PRIVATE
  }).execute
end

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #585917

Payton Burdette (199f814f) at 11 Mar 16:36

@hfyngvason I added preload to app/graphql/resolvers/ci/project_pipelines_resolver.rb (duo called this out to earlier !226869 (comment 3150791161)

Update the related N+1 tests for that query

Where would I need to do this at?

Payton Burdette (be4a3b43) at 11 Mar 15:14

Ahh got it thanks @GitLabDuo 🙇

@GitLabDuo the type app/graphql/types/ci/pipeline_schedule_type.rb has authorize :read_pipeline_schedule is that not enough?

@GitLabDuo would we add pipeline_schedule: [] to the preloads method in app/graphql/resolvers/ci/project_pipelines_resolver.rb ?

Payton Burdette (8fa07e16) at 11 Mar 14:16