Pierre GIRAUD (4005d52e) at 20 Mar 07:17
Configure instance default name via site settings
... and 1 more commit
You're right. Any is a leftover from a previous implementation.
I'll change that accordingly to the class name change.
I wanted to stick to click naming. But I agree that it would be much easier to understand with cli.OptionalArgument converted to click.Argument(required=False).
Pierre GIRAUD (d3bf517b) at 20 Mar 07:10
fixup! Configure instance default name via site settings
... and 3 more commits
As discussed this morning, I added a commit to first get rid of cli.Argument (ie. to only use cli.Option) before re-adding it with no inheritance between the two annotation classes.
Please review again.
close #529
Pierre GIRAUD (755e2684) at 19 Mar 10:32
Configure instance default name via site settings
... and 4 more commits
Pierre GIRAUD (39db3243) at 19 Mar 10:27
Configure instance default name via site settings
... and 3 more commits
I removed anything related to "host" in the commits.
Pierre GIRAUD (15c372b1) at 17 Mar 13:07
Allow only one instance to be created
in other words, I think it's a good idea to show in the template all the variables that will end up in the postgres exporter configuration file.
The idea for me is to show that this DATA_SOURCE_NAME setting was not forgotten, and to prevent the user from being tempted to add it. I thought that a comment would be enough, but it's OK for me to override it whatever happens. It's safer.
Pierre GIRAUD (d7e6a9b0) at 17 Mar 11:33
Configure instance default name via site settings
Pierre GIRAUD (dc39826d) at 17 Mar 11:31
Allow instance default name to configured in settings
... and 5 more commits
Pierre GIRAUD (f316f016) at 17 Mar 11:09
Make instance name optional
Pierre GIRAUD (bdb17c3e) at 17 Mar 10:12
Make instance name optional
Pierre GIRAUD (568b8c8a) at 17 Mar 09:08
Allow only one instance to be created
... and 10 more commits