Roy Liu activity https://gitlab.com/rliu-gl 2026-03-17T15:19:37Z tag:gitlab.com,2026-03-17:5213485478 Roy Liu approved merge request !227498: Update premium groups billing page at GitLab.org / GitLab 2026-03-17T15:19:37Z rliu-gl Roy Liu

What does this MR do and why?

Update Premium billing page to adapt trial flow changes

References

Screenshots or screen recordings

Before After
Screenshot_2026-03-17_at_10.11.02 Screenshot_2026-03-16_at_14.58.05

How to set up and validate locally

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #587958

tag:gitlab.com,2026-03-17:5213484550 Roy Liu commented on merge request !227498 at GitLab.org / GitLab 2026-03-17T15:19:25Z rliu-gl Roy Liu

LGTM! @jivanvl can you do the maintainer review?

tag:gitlab.com,2026-03-17:5213454377 Roy Liu commented on merge request !227498 at GitLab.org / GitLab 2026-03-17T15:13:38Z rliu-gl Roy Liu

suggestion (non-blocking): I remember seeing warnings in the Danger bot about not using classes like gl-bg-blue-50 (maybe only when in vue files). Instead, we should use the semantic equivalent. I found that gl-bg-feedback-info maps to gl-bg-blue-50 in light mode: https://design.gitlab.com/tailwind-documentation/background-color. But the context of this banner does not really fit the "feedback-info" wording, so I am not sure.

tag:gitlab.com,2026-03-17:5212849906 Roy Liu commented on merge request !227538 at GitLab.org / GitLab 2026-03-17T13:17:35Z rliu-gl Roy Liu

@cngo thanks for reviewing! Yes, there's quite a bit of unreachable code that can be deleted; I'll address that in separate MRs.

tag:gitlab.com,2026-03-17:5212842504 Roy Liu commented on merge request !227538 at GitLab.org / GitLab 2026-03-17T13:16:08Z rliu-gl Roy Liu

Yeah, the old billing app and components are quite large, so I plan to remove them entirely in a separate MR.

tag:gitlab.com,2026-03-16:5209887571 Roy Liu commented on merge request !227538 at GitLab.org / GitLab 2026-03-16T19:53:43Z rliu-gl Roy Liu

@vvempati can you do the initial frontend review?

tag:gitlab.com,2026-03-16:5209886776 Roy Liu commented on merge request !227538 at GitLab.org / GitLab 2026-03-16T19:53:23Z rliu-gl Roy Liu

@pgascouvaillancourt can you do the initial backend and test review?

tag:gitlab.com,2026-03-16:5209886476 Roy Liu pushed to project branch duo/feature/593618-ff-cleanup-enable-free-purchase-dap-monthly-commit-3155708 at GitLab.org / GitLab 2026-03-16T19:53:16Z rliu-gl Roy Liu

Roy Liu (de9b1366) at 16 Mar 19:53

chore: Remove enable_free_purchase_dap_monthly_commit feature flag

tag:gitlab.com,2026-03-16:5209781651 Roy Liu pushed to project branch duo/feature/593618-ff-cleanup-enable-free-purchase-dap-monthly-commit-3155708 at GitLab.org / GitLab 2026-03-16T19:17:39Z rliu-gl Roy Liu

Roy Liu (7855b05c) at 16 Mar 19:17

chore: Remove enable_free_purchase_dap_monthly_commit feature flag

tag:gitlab.com,2026-03-16:5209572310 Roy Liu opened merge request !227538: chore: cleanup enable_free_purchase_dap_monthly_commit FF at GitLab.org / GitLab 2026-03-16T18:09:51Z rliu-gl Roy Liu

Relates to https://gitlab.com/gitlab-org/gitlab/-/work_items/593618

Summary

This MR removes the enable_free_purchase_dap_monthly_commit feature flag, it has been rolled out to 100% in production since March 12th: https://gitlab.com/gitlab-com/gl-infra/feature-flag-log/-/work_items/55737.

Permanently enabling the new group billing's page for free and trial namespaces. It also productizes some UX updates for Trial CTAs on GitLab Credits Page, GitLab Duo Page and End of Trial Modal.

Unreachable code (mostly frontend) will be cleanup in follow-up MRs to keep this MR small for review.

tag:gitlab.com,2026-03-16:5209523209 Roy Liu commented on merge request !224733 at GitLab.org / GitLab 2026-03-16T17:55:49Z rliu-gl Roy Liu

@dstull Addressed the latest comments 🏓

tag:gitlab.com,2026-03-16:5209508472 Roy Liu pushed to project branch duo/refactor/584325-migrate-lwr-signup-spec-2978897 at GitLab.org / GitLab 2026-03-16T17:51:35Z rliu-gl Roy Liu

Roy Liu (985c1e62) at 16 Mar 17:51

Apply reviewer suggestions

tag:gitlab.com,2026-03-16:5209433456 Roy Liu commented on merge request !224733 at GitLab.org / GitLab 2026-03-16T17:28:40Z rliu-gl Roy Liu

Good point, adding the failure path.

tag:gitlab.com,2026-03-16:5209427916 Roy Liu commented on merge request !224733 at GitLab.org / GitLab 2026-03-16T17:26:58Z rliu-gl Roy Liu

We shouldn't need to, at the point of rendering resubmit component, these three fields are already stored in onboarding_status, CreateLeadService just reads them from database.

tag:gitlab.com,2026-03-16:5209427403 Roy Liu commented on merge request !224733 at GitLab.org / GitLab 2026-03-16T17:26:50Z rliu-gl Roy Liu

Thanks for catching this.

tag:gitlab.com,2026-03-16:5208237470 Roy Liu commented on merge request !226360 at GitLab.org / GitLab 2026-03-16T13:08:09Z rliu-gl Roy Liu

@mbenayoun thanks for reviewing, can you help set merge?