The test failures also seem to be unrelated.
The coverage issue it not related to FF removal so I am adding pipeline:skip-undercoverage and also we will be removing that code as a followup
I have addressed this but I forgot to push
As suggested by you I have moved these changes also in this MR.
Siddharth Dungarwal (b4ab03f4) at 19 Mar 13:14
Merge branch '587248-remove-visibility-specs' into 587248-navigatio...
... and 1 more commit
This code change removes test files and test code related to a feature flag called search_scope_work_item. This is 1st out of the 3 MRs for FF cleanup.
| Before | After |
|---|---|
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #587248
Siddharth Dungarwal (6fc74401) at 19 Mar 13:11
Add review fixes
Siddharth Dungarwal (16d86ae7) at 19 Mar 02:27
Fix failing specs
Siddharth Dungarwal (bf555fb9) at 18 Mar 23:09
Fix failing spec
Siddharth Dungarwal (89de2652) at 18 Mar 23:02
Fix failing specs
Update prompt to follow commit guidelines
In 36e97f19, housekeeper generated a commit message that was 500 words long and caused the pipeline to fail due to not following guidelines. This change adds some direction to the prompt to follow the guidelines.
| Before | After |
|---|---|
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Add conversion so that when someone searches using the old scope names ("issues" or "epics"), the system automatically translates them to use "work_items" instead. This ensures backward compatibility, existing bookmarks, saved searches, or API calls using the old names will continue to work seamlessly.
The implementation includes a mapping table that defines which old scope names should be converted to which new ones, and comprehensive tests to verify the conversion works correctly in various scenarios including when no scope is specified or when different parameter formats are used.
| Before | After |
|---|---|
Test Case 1: Legacy issues scope Visit: http://gdk.test:3000/search?search=test&group_id=29&scope=issues
Test Case 2: Canonical work_items scope (regression test) Visit: http://gdk.test:3000/search?search=test&group_id=29&scope=work_items
Test Case 3: Other scopes (regression test) Visit: http://gdk.test:3000/search?search=test&group_id=29&scope=blobs
Test Case 4: No scope parameter Visit: http://gdk.test:3000/search?search=test&group_id=29
Test Case 5: EE epics scope (if in EE environment) Visit: http://gdk.test:3000/search?search=test&group_id=29&scope=epics
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #593979
Siddharth Dungarwal (c5a858e7) at 18 Mar 20:53
Add changes to redirect old scopes to work_items
Can you have a look now ? I have applied one suggestion and responded to others.
I think for migrations we have all details in !227316 (comment 3158643140) generated via database testing pipeline.
Thanks for the suggestion! However, we don't need to test for nil search in this case. The search column on application_settings was added in a previous major release and is guaranteed to exist by the time this migration runs. This migration is purely a backfill operation to add the global_search_work_items_enabled key within the existing search hash, not to initialize the search column itself.
Since we're only backfilling a specific key and the column always exists, adding a test for the nil case would be testing a scenario that can't occur in practice.
Siddharth Dungarwal (afb7bb21) at 18 Mar 18:46
Apply 1 suggestion(s) to 1 file(s)
application_setting.search cannot be null it was added in last major release and has backfilled data for other columns
Thanks for clarifying!