Skip R. activity https://gitlab.com/slice 2024-09-19T16:16:23Z tag:gitlab.com,2024-09-19:3662614353 Skip R. commented on issue #11854 at George Nachman / iterm2 2024-09-19T16:16:23Z slice Skip R. [email protected]

In the debug log, you did nvim --clean,

I can't find the string nvim --clean in the debug log. I did find nvim --cmd though…

In the screen recording, nvim --clean appears as a suggestion, which might be confused for the actual command that is being ran, because Fish renders suggestions inline.

tag:gitlab.com,2024-09-13:3641862415 Skip R. commented on issue #11854 at George Nachman / iterm2 2024-09-13T21:48:01Z slice Skip R. [email protected]

Even if the pref is enabled, Neovim doesn't like it when I resize the window. There seems to be some issues around resizing in general.

tag:gitlab.com,2024-09-13:3641851413 Skip R. opened issue #11854: Using 1337;SetProfile= to change the font causes the terminal to misbehave in 3.5.5beta1 when "Adjust window when changing font ... 2024-09-13T21:38:49Z slice Skip R. [email protected]

Bug report

I was on previous beta version (unsure which one, exactly). I updated today and noticed that this began misbehaving.

  • iTerm2 version: 3.5.5beta1

  • OS version: Sonoma 14.6.1 (23G93)

  • Attach ~/Library/Preferences/com.googlecode.iterm2.plist here (drag-drop from finder into this window) com.googlecode.iterm2.plist

  • Attach a debug log, if possible.

  • Attach a screen capture video if it would make the reproduction steps clearer. debuglog.txt

PLEASE ATTACH YOUR PLIST FILE FOR BUG REPORTS! Seriously! I'll probably ask you for it if you don’t.

Detailed steps to reproduce the problem

  1. Ensure that the "Adjust window when changing font size" preference is disabled within Settings > General > Window.
  2. Send \27;]1337;SetProfile= to set the profile when launching a program (in my case, Neovim). This new terminal profile modifies the font and background color.

Here is the Lua code responsible for sending the directive to iTerm: https://github.com/slice/nixfiles/blob/28f1ad5115e789b8283f2e39303cf4eda41a8847/nvim/lua/skip/assimilate.lua#L7-L9

What happened

Inputting any text does not work correctly. I think iTerm2 isn't noticing that the terminal dimensions need to change when the profile changes, while still keeping the window the same size. If I enable this preference, then it seems to work just fine.

What should have happened

In accordance with the preference being disabled, the terminal should adjust the size of the character grid without touching the size of the actual Cocoa window itself.


tag:gitlab.com,2024-05-15:3361288153 Skip R. commented on merge request !147 at elixi.re / elixire 2024-05-15T02:23:57Z slice Skip R. [email protected]

ahhhhhhhhhhhhhhhhhh

tag:gitlab.com,2024-05-14:3361074250 Skip R. commented on merge request !147 at elixi.re / elixire 2024-05-14T23:10:48Z slice Skip R. [email protected]

lgtm otherewise..

tag:gitlab.com,2024-05-14:3361074233 Skip R. commented on merge request !147 at elixi.re / elixire 2024-05-14T23:10:47Z slice Skip R. [email protected]

are we planning to add future methods to this interface? if not, then could it just be a function instead? (i prefer free functions over classes with single method)

tag:gitlab.com,2024-05-14:3361074227 Skip R. commented on merge request !147 at elixi.re / elixire 2024-05-14T23:10:47Z slice Skip R. [email protected]
        mailgun_url = f"https://api.mailgun.net/v3/{econfig.MAILGUN_DOMAIN}/messages"

extraneous?

tag:gitlab.com,2024-03-23:3247266165 Skip R. approved merge request !146: remove discriminator from DISCORD_REGEX at elixi.re / elixire 2024-03-23T19:46:15Z slice Skip R. [email protected]

close #196

tag:gitlab.com,2024-03-23:3247266150 Skip R. commented on merge request !146 at elixi.re / elixire 2024-03-23T19:46:13Z slice Skip R. [email protected]

porra 💯

tag:gitlab.com,2024-03-23:3247265700 Skip R. approved merge request !25: drop discriminators from discord tags at elixi.re / elixire-fe 2024-03-23T19:45:05Z slice Skip R. [email protected]

close #30

tag:gitlab.com,2024-03-23:3247265672 Skip R. commented on merge request !25 at elixi.re / elixire-fe 2024-03-23T19:45:03Z slice Skip R. [email protected]

haven't tested but lgtm

tag:gitlab.com,2024-03-23:3247264539 Skip R. commented on merge request !146 at elixi.re / elixire 2024-03-23T19:42:06Z slice Skip R. [email protected]

isn't specific enough, see: frontend!25 (comment 1828988495)

need something like [a-z0-9_.]{2,32}

tag:gitlab.com,2024-03-23:3247264267 Skip R. commented on merge request !25 at elixi.re / elixire-fe 2024-03-23T19:41:25Z slice Skip R. [email protected]

2024_03_23-12-40-08-PM_2x

assuming that the entirety of DISCORD_RE match is used (i don't see any groups here), i think /[a-z0-9_.]{2,32}/i works

tag:gitlab.com,2024-03-23:3247263477 Skip R. commented on merge request !25 at elixi.re / elixire-fe 2024-03-23T19:39:41Z slice Skip R. [email protected]

oh wait this technically isn't specific enough (e.g. would allow spaces and other disallowed symbols, etc.)

tag:gitlab.com,2024-03-23:3247263201 Skip R. commented on merge request !25 at elixi.re / elixire-fe 2024-03-23T19:38:57Z slice Skip R. [email protected]

lgtm otherwise

tag:gitlab.com,2024-03-23:3247263193 Skip R. commented on merge request !25 at elixi.re / elixire-fe 2024-03-23T19:38:56Z slice Skip R. [email protected]

lmfao wtf was i on when i wrote this shitcode

tag:gitlab.com,2024-03-23:3247263189 Skip R. commented on merge request !25 at elixi.re / elixire-fe 2024-03-23T19:38:55Z slice Skip R. [email protected]
        input(type="text", placeholder="discord.username").form-control#discord

pomelo usernames can't contain capitals, also added a period to make it exceedingly clear that it's a username

tag:gitlab.com,2024-03-18:3234689241 Skip R. commented on issue #11267 at George Nachman / iterm2 2024-03-18T22:51:27Z slice Skip R. [email protected]

Sorry, it's been a while…

I think you have a nonretina mac, is that right?

Sort of, yes; when I originally opened the issue I was using a MacBook Air (M1, 2020) connected to a non-Retina monitor. The issues would manifest there.

I have since upgraded to a MacBook Pro (M3 Max, 2023) and have been using a Studio Display as well as the aforementioned non-Retina monitor as a second display. Since I effectively keep text-heavy windows on the Studio Display, this bug effectively stopped being an personal blocker. Curiously though, when I tried reproducing today, I could not reproduce many of the issues in these scenarios when using iTerm on the non-Retina monitor:

  • MacBook Pro connected to Studio Display + non-Retina monitor
  • MacBook Pro connected solely to the non-Retina monitor
  • The original MacBook Air connected to the non-Retina monitor, with the built-in display active

There were some other rendering inconsistencies between the Pro and the Air for some reason. The Pro is a much newer machine so it might be the case that I messed with some defaults relating to font rendering. I might also suspect that Apple made some changes and the behavior was improved as a result (both machines have since been updated to macOS Sonoma 14.4). If I happen to run into this again in the future, I'll give more details, but this seems to have mysteriously fixed itself for the most part.

tag:gitlab.com,2024-01-21:3104854806 Skip R. commented on issue #11267 at George Nachman / iterm2 2024-01-21T22:53:27Z slice Skip R. [email protected]

@gnachman Thanks for continuing to tackle this problem!

I tried out the adhoc build, but I think the underlying issues remain. The "stray horizontal lines" artifacts remain with PragmataPro Mono Regular 14 (and seemingly only at that size). Here's a debug log of me creating a window with that font: debuglog.txt, and a screenshot:

2024_01_21-02-43-26-PM

This issue is subtle; it's only a few pixels there.

Meanwhile though, with the Iosevka Uni Regular 14 font, there appears to be more drastic artifacts by the 0 glyph: 2024_01_21-02-46-32-PM, and also b: 2024_01_21-02-47-36-PM

Here's a debug log of me creating a window with that font: debuglog.txt

The problem can also worsen with font size; here's Iosevka Uni Regular 20:

2024_01_21-02-49-47-PM

This seems somewhat similar to before.

If it helps, I've also recorded a video (and wrote a small Cocoa app to constantly display a timestamp, to help correlate it with a log) here: https://skip.lol/iterm_video-2024-01-21.mp4 (ignore the fiddling with my text editor, I forgot my keybinds!)

And the debug log for that session (143 MB!) is here: https://skip.lol/iterm_video_debuglog_2024-01-21.txt

tag:gitlab.com,2023-12-28:3059894371 Skip R. commented on issue #11267 at George Nachman / iterm2 2023-12-28T00:16:21Z slice Skip R. [email protected]

Alright, here is a frame capture with PragmataPro Mono Regular at 14pt:

iTerm2-frame-capture.zip

ss1

Here is another frame capture demonstrating the other issue, with Iosevka Uni Regular at 14pt:

iTerm2-frame-capture.zip

2023_12_27-04-15-52-PM