Context: !217657 (comment 2983878619)

Closing this issue for now as the product does not prioritize this for now.

The MR got merged: gitlab!227883 (merged)

I'll wait till it's in prod to verify this issue.

@sming-gitlab / @dpisek ahh I was convinced isPipelineRunning = !isPipelineActive because both of them has hasPipeline check. If we remove isPipelineRunning and use only !isPipelineActive, we'll then show running status for cases where hasPipeline is false. Now I understand, sorry about the confusion.

That said, I think the following is more readable:

pipelineState() {
  if (!this.mr) return 'loading';
  if (!this.mr.pipelineIid) return 'no-pipeline';
  if (this.mr.isPipelineActive) return 'running';
  return 'complete';
} 

// ...

statusMessage() {
  if (this.pipelineState === 'running') return s__('MrReports|Waiting for pipeline to complete.');
  if (this.pipelineState === 'no-pipeline') return s__('MrReports|No pipelines started yet...');
  return '';
},

We can also use CONSTANTS instead of checking by string, so we can see what states are there by simply looking at these constants at the top of file. WDYT?

Savas Vedova (76e62bfc) at 19 Mar 11:02

Savas Vedova (8588604f) at 19 Mar 11:02

... and 1 more commit

What does this MR do and why?

Add vulnerabilities by age chart to project dashboard

Implement the Vulnerabilities By Age chart for the project-level security dashboard, bringing feature parity with the group-level dashboard while appropriately simplifying for project-level scope.

References

Screenshots or screen recordings

How to set up and validate locally

1. Enable feature flag: project_total_risk_score_chart (http://gdk.test:3000/rails/features/project_vulnerabilities_by_age_chart)
2. Make sure to have a project with vulnerabilities
3. Visit Secure > Security Dashboard
4. Validate Vulnerabilities By Age is showing as expected

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to gitlab-org#21021

As a side note: should including the applied filters in the PDF export be tracked as a separate issue?

@bryan_valdiviezo do you mean displaying them in the PDF export?

Regarding the implementation, sounds good, I'll see what I can deliver this week.

I'm picking this up.

@dpisek / @sming-gitlab the confusion for me is that isPipelineRunning is literally !isPipelineComplete in the current implementation. I was suggesting dropping the computed property because we can simply do !isPipelineComplete. So I'm not sure if the current implementation reflects the logic mentioned above.

@lorenzvanherwaarden since Total Risk Score got merged, we can now view the Dashboard with all 3 charts. I updated the MR description with the screenshot.

Can you please re-approve so that we can merge this one as well?

Adjusted label to typefeature featureaddition

Savas Vedova (76e62bfc) at 19 Mar 09:36

... and 262 more commits

Savas Vedova (89bf7077) at 19 Mar 09:22

... and 267 more commits

The MR now got merged 👍 Waiting for it to go in production so that I can test it.

Awesome, thank you both! I'll go ahead and update Poll.js to and make the new feature opt-in.

@sming-gitlab great work! Left a question 🏓

question @sming-gitlab is this needed? Can't we use !isPipelineComplete, which implies the pipeline is still running? It feels a bit redundant.

@dpisek left a nitpick, please feel free to implement it in a follow up MR if you find value in it.

I'm going to approve and set auto merge as I don't want to block the MR for coding style 👍