@brytannia I added tests for when the namespace_id is nil. Can you please take a look?

Tomas Bulva (6ee7ea53) at 18 Mar 17:10

... and 219 more commits

Tomas Bulva (b88c501f) at 18 Mar 16:54

Tomas Bulva (929ab7a5) at 18 Mar 16:54

... and 1 more commit

What does this MR do?

This change consolidates and reorganizes how chat message types are defined and used throughout the codebase. Instead of having message type constants scattered in multiple files, they're now centralized in a single location (constants.js) using a MESSAGE_MODEL_ROLES object.

The code updates all references to use this new centralized system - this includes test files, story files, and component files that handle different types of chat messages (like agent messages, user messages, tool messages, etc.). The functionality remains exactly the same, but the code is now better organized and easier to maintain since all message type definitions live in one place rather than being duplicated across multiple files.

This is essentially a "housekeeping" change that makes the code cleaner and more maintainable without changing how the chat system actually works for users.

Screenshots or screen recordings

N/A

Integration merge requests

• GitLab: mr_url
• CustomersDot: mr_url
• Status Page: mr_url

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

• Code review guidelines.
• GitLab UI's contributing guidelines.
• If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
• If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
• If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
• Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

• All actions and functionality can be done with a keyboard.
• Links, buttons, and controls have a visible focus state.
• All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
• Changes in a component's state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
• Color combinations have sufficient contrast.

Hi @ealcantara, I checked this against the monolith as well as agains the IDE. It looks great!!

What does this MR do?

This change consolidates and reorganizes how chat message types are defined and used throughout the codebase. Instead of having message type constants scattered in multiple files, they're now centralized in a single location (constants.js) using a MESSAGE_MODEL_ROLES object.

The code updates all references to use this new centralized system - this includes test files, story files, and component files that handle different types of chat messages (like agent messages, user messages, tool messages, etc.). The functionality remains exactly the same, but the code is now better organized and easier to maintain since all message type definitions live in one place rather than being duplicated across multiple files.

This is essentially a "housekeeping" change that makes the code cleaner and more maintainable without changing how the chat system actually works for users.

Screenshots or screen recordings

N/A

Integration merge requests

• GitLab: mr_url
• CustomersDot: mr_url
• Status Page: mr_url

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

• Code review guidelines.
• GitLab UI's contributing guidelines.
• If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
• If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
• If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
• Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

• All actions and functionality can be done with a keyboard.
• Links, buttons, and controls have a visible focus state.
• All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
• Changes in a component's state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
• Color combinations have sufficient contrast.

Ha, I wish I could take credit! Since we added self to the allowed globals in .js files, ESLint no longer flagged it as a restricted global — so keeping the eslint-disable-next-line comments would've actually been incorrect. The linter made me do it 😄

Tomas Bulva (0669f371) at 18 Mar 10:26

Hi @qerub, thank you for your contribution. I will help you get this merged. Can you please add issue link to the description of this MR?

Hi @timofurrer, can you please review this MR?

Tomas Bulva (449c1831) at 17 Mar 16:40

... and 289 more commits