hi there @sayobittencourt

can you please give this one a review when you got some time? It's just a simple ui change which I thought would make sense 🤔

What does this MR do and why?

Update the revoke button icon on project/group access token page

References

#593839

Screenshots or screen recordings

Before	After

How to set up and validate locally

1. Checkout this branch and run gdk locally
2. Go to project access token or group access token page
3. Add the new active token if not present already
4. Notice the new icon(cancel icon) for revoke button previously it looked like delete button

Rinku C (447b42d6) at 17 Mar 11:02

closing as MR has been merged and deployed!

hi @psjakubowska 👋

seems like this one is fixed already 🤔 I tried editing the blob and committing and it does redirect me back to the MR correctly after that. was that the right flow I was checking or is it for some other flow? 🤔

What does this MR do and why?

Fix the simulateSass prop validation error on performance bar on development mode.

in dev mode simulateSass value comes from ENV GITLAB_SIMULATE_SAAS which can be undefined(if not passed) leading to the prop validation error. so making simulateSass prop non required and passing default value as false to fix that.

Screenshots or screen recordings

Before	After

How to set up and validate locally

1. Checkout this branch and run gdk locally
2. Open the browser console once gdk is running successfully
3. Notice the prop validation error for simulateSaas prop is not seen on console anymore

Rinku C (c113ba60) at 17 Mar 05:34

I've not got the chance to continue on this further so far 😅

So I'm closing this for now, will open up another MR when I get the chance 🙏

What does this MR do and why?

Make error and success message user friendly during username update. Currently success and error messages both shows up as alert at the top but user aren't aware of it.

Changes made:

• shows toast message for successful username update
• shows error message below input field for username validation error and server error
• checking username availability on Update username button click and only show confirmation modal if it's available

References

#584021

Screenshots or screen recordings

Before	After

How to set up and validate locally

1. Checkout this branch and run gdk locally
2. Go to update profile page eg: http://gdk.local/-/user_settings/profile
3. Try updating username with special character on the front eg: %root
4. Notice the error message appearing below the username input field
5. Try updating username to valid value eg: username100
6. Notice the success toast message

hi there @faleksic

just to let you know, there is already another issue open for this as well #593599 🙏 so maybe this can be closed as duplicate.

Rinku C (d674c638) at 16 Mar 02:08

Rinku C (aa6a764a) at 15 Mar 12:18

@GitLabDuo name property is provided from child component

Rinku C (577064ed) at 15 Mar 12:03

... and 331 more commits

thank you for the review @psjakubowska 🙇

I've addressed your suggestions now!

sure! done ✅

make sense 🤔 updated now ✅

Rinku C (6bdb8950) at 13 Mar 15:48

... and 506 more commits