Thomas Hutterer (8a43cfc3) at 18 Mar 11:13

Thomas Hutterer (370877b0) at 18 Mar 11:12

What does this MR do and why?

Add feature flag to show page breadcrumbs in page topbar

... instead of the main panel header.

This is a WIP: The panel header remains visible even though it is currently no contents.

References

Screenshots or screen recordings

Before	After

How to set up and validate locally

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #591946

Thomas Hutterer (153a3fb1) at 18 Mar 10:09

... and 528 more commits

I haven't given this a thorough review, as I'm suffering from AI generated code review fatigue

I get it 😓 And with +500 lines added (and thousands removed from vendored BSV folders), this MR is definitely big and not easy to review in one go. So thanks for having another big picture look! The first one was already super helpful to shape this.

Anyway, I've left a few comments.

@markrian I think you didn't submit your review comments yet. Can you please check? They are probably still pending 🏓

Ah yes, data-method is rails-ujs stuff. Good ol' times 😄

Assigning myself to this issue and putting it into %18.11 as I already opened Replace Bootstrap-Vue toast with lightweight co... (!5698) to get rid of BToaster & friends 🍞

/cc @vanessaotto @paintedbicycle-gitlab

frontend looks perfect! 👍

@markrian Found 1 extra method in the docs. See inline suggestion.

What does this MR do?

Make alerts programmatically focusable

See https://design.gitlab.com/components/alert/#informational-announcements-with-required-action.

Addresses #3149.

Screenshots or screen recordings

See the included screenshot test.

Integrations

• GitLab: mr_url
• CustomersDot: mr_url
• Duo UI: mr_url
• Status Page: mr_url
• Docs: mr_url
• Switchboard: mr_url

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

• The “What does this MR do?” section in the MR description is filled out, explaining the reasons for and scope of the proposed changes, per “Say why not just what”.
  • For example, if the MR is focused on usage guidelines, addressing accessibility challenges could be added in a separate MR.
• Relevant label(s) are applied to the MR.
• The MR is added to a milestone.
• Added the ~"component:*" label(s) if applicable.
• A changeset is added when this MR will do a patch, minor, or major update. More information can be found in doc/publishing-packages.md.

Components

• GitLab UI's contributing guidelines.
• If the MR changes a component's API, integration MR(s) have been opened (see integrations above).

Documentation

• If creating a new component page from scratch, it follows the page template structure.
• Content follows the GitLab Documentation Style Guide when appropriate.
• Related pages are cross-linked, where helpful. Component pages have related components and patterns defined in their Markdown front matter.
• If embedding a Figma file, it follows the Figma embed guide.
• Review requested from any GitLab designer or directly from a maintainer or trainee maintainer.
• Maintainer review follows the Pajamas UX maintainer review checklist.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

• All actions and functionality can be done with a keyboard.
• Links, buttons, and controls have a visible focus state.
• All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
• Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
• Color combinations have sufficient contrast.

Related to #3149

With gitlab-org/duo-ui!470 (merged) out of the way, the CI pipeline here is finally green

I also created gitlab-org/gitlab!227641 as integration MR and its first pipeline looks like nothing toast-related is breaking there either.

@markrian This is a rather big MR, do you still have capacity to review it? I'll go ahead and assign you now, but if you can't get to it this week, please reassign to Scott, or someone from the task group. Thanks a lot!

Thomas Hutterer (5ac87d6f) at 17 Mar 11:32

... and 1 more commit

Thomas Hutterer (9732aa44) at 17 Mar 11:31

What does this MR do and why?

Extend the leave_by_url script to support asynchronously loaded button.

Extracted off !226640 for easier review.

References

Related to #590425

Screenshots or screen recordings

How to set up and validate locally

1. Checkout !226640
2. Join a project as a member
3. Go to the project page with leave=1 param (http://localhost:3000/flightjs/Flight?leave=1)

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Thomas Hutterer (a7567d5d) at 17 Mar 11:17

Thomas Hutterer (f9259745) at 17 Mar 10:47

Thomas Hutterer (2034fa74) at 17 Mar 10:27

... and 61 more commits

Tested locally and LGTM! 👍

I left 3 non-blocking thoughts, but these can be handled after merge (or just not 😄)

Let's get this merged ... 🚀

What does this MR do and why?

Extend the leave_by_url script to support asynchronously loaded button.

Extracted off !226640 for easier review.

References

Related to #590425

Screenshots or screen recordings

How to set up and validate locally

1. Checkout !226640
2. Join a project as a member
3. Go to the project page with leave=1 param (http://localhost:3000/flightjs/Flight?leave=1)

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

thought (non-blocking): The error var is never used. I am surprised our linting did not complain about it.