Artem activity https://gitlab.com/tim74 2023-10-16T12:11:43Z tag:gitlab.com,2023-10-16:2906972877 Artem commented on issue #382 at Fedora / Fedora Legal / fedora-license-data 2023-10-16T12:11:43Z tim74 Artem

Thanks for review!

tag:gitlab.com,2023-10-15:2905592756 Artem opened issue #382: License Review: python-colorthief at Fedora / Fedora Legal / fedora-license-data 2023-10-15T22:19:05Z tim74 Artem

License Review Request

License name

None

Text of license

https://github.com/fengsp/color-thief-py/blob/master/LICENSE

python-colorthief

https://github.com/fengsp/color-thief-py

Is this license on the SPDX License List?

No

Reason for license review

https://bugzilla.redhat.com/show_bug.cgi?id=2244307

tag:gitlab.com,2023-10-12:2901877374 Artem opened issue #3669: Some screenshots in AppData broken at Adam Honse / OpenRGB 2023-10-12T21:30:10Z tim74 Artem

Some screenshot links for AppData broken, 404. We need to update some of them. This prevent to update runtime on Flathub currently.

Description of Bug

builddir/files/share/appdata/org.openrgb.OpenRGB.appdata.xml: FAILED:
• file-invalid          : <screenshot> failed to load [https://gitlab.com/CalcProgrammer1/OpenRGB/-/wikis/uploads/e1d8d4603ecdd04f1acbcf6b2314fc66/OpenRGB_0.31_Device_View.PNG]

Attached Log

https://buildbot.flathub.org/#/builders/6/builds/73052

Operating System

OS - Linux

tag:gitlab.com,2023-09-15:2845054058 Artem commented on issue #345 at Fedora / Fedora Legal / fedora-license-data 2023-09-15T14:49:42Z tim74 Artem

Thanks for review. Maybe we could package just source code of opentyrian and document how to install data files? This question probably out of scope of this issue, but don't know where to discuss this.

tag:gitlab.com,2023-09-13:2840354826 Artem opened issue #345: opentyrian data files licence at Fedora / Fedora Legal / fedora-license-data 2023-09-13T22:12:03Z tim74 Artem

License Review Request

License name

Text of license

Tyrian was released as Freeware in 2004.

From http://www.freewebs.com/worldtreegames/ :

Feel free to play it all you want and share it with friends, but for the moment I'd like to just have a central backup place (here) for the game. In the future I might not mind other sites sharing it, but I do enjoy amusing fans. :)

From http://www.camanis.net/ :

Tyrian has been released as freeware by Jason Emery.

These terms overide the one from the license.doc present in tyrian21.zip.

Is this license on the SPDX License List?

Data files, assets - no.

Reason for license review

https://bugzilla.redhat.com/show_bug.cgi?id=2155166

tag:gitlab.com,2023-03-15:2469667353 Artem deleted project branch gcc13-fix at Artem / OpenRGB 2023-03-15T20:34:38Z tim74 Artem

Artem (02d72bb4) at 15 Mar 20:34

tag:gitlab.com,2023-03-15:2469607887 Artem opened merge request !1743: Fix building with GCC 13 at Adam Honse / OpenRGB 2023-03-15T19:57:26Z tim74 Artem

https://gcc.gnu.org/gcc-13/porting_to.html

fix: #3225

tag:gitlab.com,2023-03-15:2469604105 Artem pushed to project branch gcc13-fix at Artem / OpenRGB 2023-03-15T19:55:30Z tim74 Artem

Artem (02d72bb4) at 15 Mar 19:55

Fix building with GCC 13

tag:gitlab.com,2023-03-15:2469601151 Artem pushed new project branch gcc13-fix at Artem / OpenRGB 2023-03-15T19:53:38Z tim74 Artem

Artem (15ef2e70) at 15 Mar 19:53

Fix building with GCC 13

... and 882 more commits

tag:gitlab.com,2023-03-14:2464251413 Artem commented on issue #3225 at Adam Honse / OpenRGB 2023-03-14T03:23:57Z tim74 Artem

I thought this could due uint8_t in ../Controllers/SteelSeriesController/SteelSeriesMouseController.cpp:58:5 perhaps?

In file included from ../Controllers/SteelSeriesController/SteelSeriesMouseController.cpp:10:
../Controllers/SteelSeriesController/SteelSeriesMouseController.h:40:17: error: 'uint8_t' was not declared in this scope
   40 |     std::vector<uint8_t>    modes;
      |                 ^~~~~~~
../Controllers/SteelSeriesController/SteelSeriesMouseController.h:13:1: note: 'uint8_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
   12 | #include "SteelSeriesGeneric.h"
  +++ |+#include <cstdint>
   13 | 
../Controllers/SteelSeriesController/SteelSeriesMouseController.h:40:24: error: template argument 1 is invalid
   40 |     std::vector<uint8_t>    modes;
      |                        ^
../Controllers/SteelSeriesController/SteelSeriesMouseController.h:40:24: error: template argument 2 is invalid
../Controllers/SteelSeriesController/SteelSeriesMouseController.h:62:36: error: 'uint8_t' has not been declared
   62 |     virtual void                SetLightEffectAll(uint8_t effect)                                   = 0;
      |                                    ^~~~~~~
../Controllers/SteelSeriesController/SteelSeriesMouseController.cpp: In member function 'virtual void SteelSeriesMouseController::Save()':
../Controllers/SteelSeriesController/SteelSeriesMouseController.cpp:57:11: error: 'uint8_t' does not name a type
   57 |     const uint8_t   SAVE_BUFFER_SIZE            = 10;
      |           ^~~~~~~
../Controllers/SteelSeriesController/SteelSeriesMouseController.cpp:11:1: note: 'uint8_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
   10 | #include "SteelSeriesMouseController.h"
  +++ |+#include <cstdint>
   11 | 
../Controllers/SteelSeriesController/SteelSeriesMouseController.cpp:58:5: error: 'uint8_t' was not declared in this scope
   58 |     uint8_t         usb_buf[SAVE_BUFFER_SIZE]   = { 0x00, 0x09 };
      |     ^~~~~~~
../Controllers/SteelSeriesController/SteelSeriesMouseController.cpp:58:5: note: 'uint8_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
../Controllers/SteelSeriesController/SteelSeriesMouseController.cpp:60:20: error: 'usb_buf' was not declared in this scope
   60 |     hid_write(dev, usb_buf, SAVE_BUFFER_SIZE);
      |                    ^~~~~~~
../Controllers/SteelSeriesController/SteelSeriesMouseController.cpp:60:29: error: 'SAVE_BUFFER_SIZE' was not declared in this scope
   60 |     hid_write(dev, usb_buf, SAVE_BUFFER_SIZE);
      |                             ^~~~~~~~~~~~~~~~
make: *** [Makefile:8629: SteelSeriesMouseController.o] Error 1

Missed types? Maybe similar to this fix in other project?

tag:gitlab.com,2023-03-13:2464012741 Artem opened issue #3225: FTBFS with new GCC 13 at Adam Honse / OpenRGB 2023-03-13T23:26:57Z tim74 Artem

Description of Bug

Failed to build with new GCC 13.

Attached Log

Operating System

OS - Linux

Additional info

Compiler:

  • GCC 13.0.1

https://gcc.gnu.org/gcc-13/porting_to.html

tag:gitlab.com,2023-02-20:2418904338 Artem commented on issue #346 at CoreCtrl / CoreCtrl 2023-02-20T12:33:29Z tim74 Artem

Sure, great change! New version with unbundled libs already built for all current Fedora branches. Need a proper testing though. Fedora users please welcome https://bodhi.fedoraproject.org/updates/?packages=corectrl

tag:gitlab.com,2022-09-17:2120349140 Artem commented on issue #48 at Jason Oickle / OpenWeather 2022-09-17T20:29:11Z tim74 Artem

Added patch for F37+. Build available for testing. Thanks!

tag:gitlab.com,2022-09-08:2102736167 Artem opened issue #50: GNOME v43: only says &quot;Loading ...&quot; without ever showing the weather at Jason Oickle / OpenWeather 2022-09-08T15:01:14Z tim74 Artem

OpenWeather only says "Loading ..." without ever showing the weather in new upcoming GNOME v43. Works fine in GNOME v42.

  • OpenWeather version: 118
  • Distro: Fedora 37 (Pre-release)
  • GNOME: v43.RC
tag:gitlab.com,2021-12-29:1640667341 Artem commented on merge request !933 at Adam Honse / OpenRGB 2021-12-29T09:30:17Z tim74 Artem

Thanks. Just now arrived my device which should supported by OpenRGB and i finally could test myself app and everything related to udev rules and such...

tag:gitlab.com,2021-12-23:1634610457 Artem commented on issue #1179 at Adam Honse / OpenRGB 2021-12-23T12:12:44Z tim74 Artem

Folks who interesting in this app please help with testing flatpak build.

tag:gitlab.com,2021-12-23:1634607348 Artem commented on merge request !933 at Adam Honse / OpenRGB 2021-12-23T12:11:01Z tim74 Artem

I'll rebase this ASAP. And sorry for some delay here - i am seeking for testers at this moment. We tried to test this and original AppImage build without this MR and for some reasons Thermaltake-Riing didn't found by app, but it mentioned in supported devices on the wiki. I'll also ask to test RPM version these folks. And also would be nice if people from original issue help with testing...

tag:gitlab.com,2021-12-23:1633850206 Artem deleted project branch appdata at Artem / OpenRGB 2021-12-23T03:50:27Z tim74 Artem

Artem (81b58705) at 23 Dec 03:50

tag:gitlab.com,2021-12-21:1629838888 Artem commented on issue #162 at Roberto Leinardi / GreenWithEnvy 2021-12-21T07:16:00Z tim74 Artem

Great, update submitted in Fedora.

tag:gitlab.com,2021-12-14:1619035433 Artem commented on merge request !933 at Adam Honse / OpenRGB 2021-12-14T20:35:02Z tim74 Artem

@Dr_No i have some doubts here because didn't tested on other distros, but is should work. Also after some talks with Debian folks and they said Debian already have packages which installs udev rules in such location:

# apt-file search /usr/lib/udev/rules.d/
light: /usr/lib/udev/rules.d/90-backlight.rules
ltunify: /usr/lib/udev/rules.d/42-logitech-unify-permissions.rules
mobile-tweaks-common: /usr/lib/udev/rules.d/90-nm-gadget-managed.rules
util-linux: /usr/lib/udev/rules.d/85-hwclock.rules
xpra: /usr/lib/udev/rules.d/71-xpra-virtual-pointer.rules

And some background.