Tan Le activity

Tan Le commented on issue #888 at GitLab.org / ModelOps / AI Assisted (formerly Applied ML) / Code Suggestions / AI Gateway

2026-03-17T14:34:10Z

Completed as per !4374 (merged)

Tan Le closed issue #888: fix: tests/code_suggestions/test_completions.py has 43 mypy errors at GitLab.org / ModelOps / AI Assisted (formerly Applied ML) / ...

2026-03-17T14:34:03Z

Tan Le commented on merge request !4906 at GitLab.org / ModelOps / AI Assisted (formerly Applied ML) / Code Suggestions / AI Gateway

2026-03-17T14:21:11Z

👋 @alejandro, could you help to review this MR, please? 🙏

Tan Le pushed to project branch mypy-group1-simple-fixes at GitLab.org / ModelOps / AI Assisted (formerly Applied ML) / Code Suggestions / AI Gateway

2026-03-17T14:17:27Z

Tan Le (19aa4218) at 17 Mar 14:17

chore(mypy): fix mypy type errors

Tan Le commented on merge request !4906 at GitLab.org / ModelOps / AI Assisted (formerly Applied ML) / Code Suggestions / AI Gateway

2026-03-17T10:39:41Z

Addressed in 3ef1db44

Tan Le commented on merge request !4906 at GitLab.org / ModelOps / AI Assisted (formerly Applied ML) / Code Suggestions / AI Gateway

2026-03-17T10:39:33Z

Addressed in 3ef1db44

Tan Le pushed to project branch mypy-group1-simple-fixes at GitLab.org / ModelOps / AI Assisted (formerly Applied ML) / Code Suggestions / AI Gateway

2026-03-17T10:38:55Z

Tan Le (3ef1db44) at 17 Mar 10:38

chore(mypy): fix mypy type errors

... and 44 more commits

Tan Le commented on issue #840 at GitLab.org / ModelOps / AI Model Validation and Research / AI Evaluation / CEF

2026-03-17T10:22:39Z

@HongtaoYang I haven't seen this error before. Can you share which command was used so I can try to reproduce on my end?

Tan Le pushed to project branch mypy-group1-simple-fixes at GitLab.org / ModelOps / AI Assisted (formerly Applied ML) / Code Suggestions / AI Gateway

2026-03-17T10:20:44Z

Tan Le (ca09f9b6) at 17 Mar 10:20

chore(mypy): fix mypy type errors

Tan Le commented on merge request !4906 at GitLab.org / ModelOps / AI Assisted (formerly Applied ML) / Code Suggestions / AI Gateway

2026-03-17T07:44:28Z

Scope should work fine as it's the base type that includes all the necessary ASGI scope information.

No, it is not for WWWScope in uvicorn lib.

Tan Le commented on merge request !4906 at GitLab.org / ModelOps / AI Assisted (formerly Applied ML) / Code Suggestions / AI Gateway

2026-03-17T07:38:07Z

@GitLabDuo This is unfortunate but the only option I can think of given the signature of the get_path_with_query_string function.

Tan Le approved merge request !2032: Make timeout configurable for remote executor at GitLab.org / ModelOps / AI Model Validation and Research / AI Evaluati...

2026-03-17T07:19:06Z

What does this merge request do and why?

Add timeout to remote executor

How to set up and validate locally

Configure a low timeout in your config and run an eval.

env:
  executor_type: "remote"
  timeout: 10

You should see the eval failing after 10s for each example.

Merge request checklist

I've ran the affected pipeline(s) to validate that nothing is broken.
Tests added for new functionality. If not, please raise an issue to follow up.
Documentation added/updated, if needed.

Tan Le commented on merge request !2032 at GitLab.org / ModelOps / AI Model Validation and Research / AI Evaluation / CEF

2026-03-17T06:46:36Z

suggestion: It does not seem that we need this ignore marker 🤔

                timeout=executor_yaml_config.params.timeout,

Tan Le commented on merge request !2032 at GitLab.org / ModelOps / AI Model Validation and Research / AI Evaluation / CEF

2026-03-17T06:17:16Z

suggestion (non-blocking): Could we also add this to the issue-to-mr.yaml?

Tan Le deleted project branch ankit.panchal/improve-internal-events-delivery at GitLab.org / ModelOps / AI Assisted (formerly Applied ML) / Code Suggestions...

2026-03-17T05:56:15Z

Tan Le (0044ac0b) at 17 Mar 05:56

Tan Le pushed to project branch main at GitLab.org / ModelOps / AI Assisted (formerly Applied ML) / Code Suggestions / AI Gateway

2026-03-17T05:56:14Z

Tan Le (adced3d5) at 17 Mar 05:56

Merge branch 'ankit.panchal/improve-internal-events-delivery' into ...

... and 1 more commit

Tan Le accepted merge request !4807: fix: add graceful shutdown flush, and logging for internal events at GitLab.org / ModelOps / AI Assisted (formerly Appl...

2026-03-17T05:56:11Z

What does this merge request do and why?

Summary

Add graceful shutdown flush via tracker.flush() to prevent event loss during pod restarts

Numbered steps to set up and validate the change are strongly suggested.

Merge request checklist

Tests added for new functionality. If not, please raise an issue to follow up.
Documentation added/updated, if needed.
If this change requires executor implementation: verified that issues/MRs exist for both Go executor and Node executor or confirmed that changes are backward-compatible and don't break existing executor functionality.

Tan Le opened merge request !4906: chore(mypy): reduce mypy errors at GitLab.org / ModelOps / AI Assisted (formerly Applied ML) / Code Suggestions / AI Gateway

2026-03-17T05:51:24Z

What does this merge request do and why?

This removes mypy errors in the following files.

ai_gateway/api/middleware/base.py
ai_gateway/code_suggestions/processing/ops.py
ai_gateway/instrumentators/model_requests.py
ai_gateway/integrations/amazon_q/test_chat.py

$ make check-mypy
--snip--
ai_gateway/code_suggestions/processing/ops.py:312: error: Argument 1 to "map" has incompatible type "type[tuple[_T_co, ...]]"; expected "Callable[[ndarray[tuple[Any, ...], dtype[signedinteger[_32Bit | _64Bit]]]], ndarray[tuple[Any, ...], dtype[signedinteger[_32Bit | _64Bit]]]]"  [arg-type]
ai_gateway/code_suggestions/processing/ops.py:314: error: Incompatible return value type (got "list[ndarray[tuple[Any, ...], dtype[signedinteger[_32Bit | _64Bit]]]]", expected "list[tuple[Any, ...]]")  [return-value]
ai_gateway/api/middleware/base.py:80: error: Argument 1 to "float" has incompatible type "str | None"; expected "str | Buffer | SupportsFloat | SupportsIndex"  [arg-type]
ai_gateway/api/middleware/base.py:111: error: Incompatible types in assignment (expression has type "Any | BaseExceptionGroup[Any]", variable has type "Exception")  [assignment]
ai_gateway/api/middleware/base.py:120: error: Argument 1 to "get_path_with_query_string" has incompatible type "MutableMapping[str, Any]"; expected "HTTPScope | WebSocketScope"  [arg-type]
ai_gateway/api/middleware/base.py:121: error: Item "None" of "Address | None" has no attribute "host"  [union-attr]
ai_gateway/api/middleware/base.py:122: error: Item "None" of "Address | None" has no attribute "port"  [union-attr]
ai_gateway/instrumentators/model_requests.py:165: error: Incompatible types in assignment (expression has type "float", variable has type "None")  [assignment]
ai_gateway/instrumentators/model_requests.py:278: error: Unsupported operand types for - ("float" and "None")  [operator]
ai_gateway/integrations/amazon_q/test_chat.py:140: error: Need type annotation for "event"  [var-annotated]
ai_gateway/integrations/amazon_q/test_chat.py:253: error: Missing named argument "shape" for "ReferenceSpan"  [call-arg]
ai_gateway/integrations/amazon_q/test_chat.py:346: error: Argument after ** must be a mapping, not "Collection[str]"  [arg-type]
ai_gateway/integrations/amazon_q/test_chat.py:381: error: Dict entry 0 has incompatible type "str": "str"; expected "str": "dict[str, str]"  [dict-item]
ai_gateway/integrations/amazon_q/test_chat.py:382: error: Dict entry 1 has incompatible type "str": "str"; expected "str": "dict[str, str]"  [dict-item]
ai_gateway/integrations/amazon_q/test_chat.py:383: error: Dict entry 2 has incompatible type "str": "str"; expected "str": "dict[str, str]"  [dict-item]
ai_gateway/integrations/amazon_q/test_chat.py:384: error: Dict entry 3 has incompatible type "str": "str"; expected "str": "dict[str, str]"  [dict-item]
Found 16 errors in 4 files (checked 927 source files)
make: *** [Makefile:226: check-mypy] Error 1

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request checklist

Tests added for new functionality. If not, please raise an issue to follow up.
Documentation added/updated, if needed.
If this change requires executor implementation: verified that issues/MRs exist for both Go executor and Node executor or confirmed that changes are backward-compatible and don't break existing executor functionality.

Tan Le pushed new project branch mypy-group1-simple-fixes at GitLab.org / ModelOps / AI Assisted (formerly Applied ML) / Code Suggestions / AI Gateway

2026-03-17T05:45:19Z

Tan Le (dd5aa2a9) at 17 Mar 05:45

chore(mypy): reduce mypy errors

Tan Le commented on merge request !2085 at GitLab.org / ModelOps / AI Model Validation and Research / AI Evaluation / CEF

2026-03-17T03:54:47Z

👋 @HongtaoYang, could you help to review this MR, please? 🙏