GitLab Ultimate customer impacted by this. GitLab Support ticket refers (internal).
The customer notices that when a job is being canceled during a helm deployment, it results in the pending-upgrade status, instead of failed. Helm introduced SIGTERM handling in Helm v3.7.0 to ensure the status is failed when given a SIGTERM:
https://github.com/helm/helm/pull/9180
The problem seems to be that the Runner does not wait for the processes to handle the signal, it just kills the containers/pods.
Michael Trainor (e4bdbaad) at 16 Mar 03:35
Add test coverage for disabled feature flag behavior
@daniel-prause @hfyngvason I'm in the process of implementing the FF as suggested. If that's not necessary, I can drop those subsequent commits. The MR is not in a mergeable state currently as the FF implementation is ongoing.
Michael Trainor (5d0a0b38) at 13 Mar 03:52
Handle nil parent when checking feature flag in fields
... and 2795 more commits