oh, apologies, I thought you were a DB maintainer
Vijay Hawoldar (abf3eff6) at 18 Mar 08:21
Merge branch 'add-spec-for-scim-group-deprovisioning-audit-details'...
... and 1 more commit
Add tests for audit event details to the group SCIM deprovisioning service specs.
Issue: #588829
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
@adil.farrukh as the changes touch the DB docs, I think we're blocked on having a DB review, even though I'd argue it's not really necessary here...
@dstull would you mind reviewing this when you get a moment?
Add tests for audit event details to the group SCIM deprovisioning service specs.
Issue: #588829
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
LGTM thanks @jagood
Preserve SAML identities in the PruneDeletionsWorker.
This means that SAML identities are preserved for users who are removed from a group via the dormant group users feature.
Ultimately, this is to solve #588829. In that issue, we will push SCIM membership removal upon user deletion into a background job using the Members::ScheduleDeletionService. This is the same service that we use during membership removal for dormant group users.
When memberships are removed during a SCIM request to delete a user, the SAML identity is preserved. When memberships are removed during dormant membership removal, the SAML identity is deleted. We believe this seems to be a minor error and can be changed - the SAML identity can be preserved in this case as well.
So in this MR, we will preserve the SAML identity during dormant membership removal, so that it will also be preserved when we use the same service during SCIM user removal.
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.