Tomas Vik (69784c48) at 17 Mar 19:12
feat(cli): adapt Duo CLI behavior for glab distribution
... and 21 more commits
I think this is tough because we've got two nouns in these commands (
mr,note) and each of the nouns requires an object, but the action is really on the second noun.🤔
@phikai yeah, note and list are both nouns and verbs, right? glab mr note, there would be a large amount of flags that would be mutually exclusive and the subcommand namespacing can IMO keep the complexity in check
Similarly...
glab mr note list- how is that different thanglab mr view --comments?
@phikai TL;DR the output is identical but without the MR metadata being attached to it, there is extra filtering on type, state and file. When my agent works with comments, it doesn't need the MR metadata most of the time.
Tomas Vik (28d6a89f) at 17 Mar 13:38
This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| @commitlint/format (source) | dependencies | minor | ^20.4.4 -> ^20.5.0 |
⚠️ WarningSome dependencies could not be looked up. Check the warning logs for more information.
MR created with the help of gitlab-org/frontend/renovate-gitlab-bot
v20.5.0
Note: Version bump only for package @commitlint/format
Note: Version bump only for package @commitlint/format
Note: Version bump only for package @commitlint/format
This MR has been generated by Renovate Bot.
Tomas Vik (1e68ce39) at 17 Mar 13:38
Merge branch 'renovate/commitlint-format-20.x' into 'main'
... and 1 more commit
Tomas Vik (50537de3) at 17 Mar 13:33
Default the SUPPORTED_TARGETS variable in compile_executables.sh using shell parameter expansion (${VAR:-default}) so callers can override it by setting the variable in the environment before invoking the script.
This is particularly useful when building the package with Nix, where only the target matching the host platform is needed and cross-compilation targets are unnecessary. The nixpkgs expression currently works around this with a sed patch (source); this change makes that workaround unnecessary.
packages/cli/scripts/compile_executables.sh: wrap the default target list with ${SUPPORTED_TARGETS:-...} so the variable can be overridden externally.Tomas Vik (774fc8c4) at 17 Mar 13:32
Merge branch 'afontaine/cli-binary-configurable-targets' into 'main'
... and 1 more commit
This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| @commitlint/format (source) | dependencies | minor | ^20.4.4 -> ^20.5.0 |
⚠️ WarningSome dependencies could not be looked up. Check the warning logs for more information.
MR created with the help of gitlab-org/frontend/renovate-gitlab-bot
v20.5.0
Note: Version bump only for package @commitlint/format
Note: Version bump only for package @commitlint/format
Note: Version bump only for package @commitlint/format
This MR has been generated by Renovate Bot.
Thanks @elwyn-gitlab, the MR LGMT
Extracts prompt history management out of TUIController into a dedicated PromptHistoryController DI service.
TUIController was handling storage initialisation, history loading, and all 7 prompt history callbacks inline. This is inconsistent with our newer features with dedicated handlers and leaves tui controller doing more than it should.
Also moved the call to load the prompt history higher in the init flow - pressing "up" or "ctrl+r" is often one of my earliest interactions and currently it feels unresponsive because we do all network initialisation before the fast filesystem history loading.
Issue #2139
mise install && npm installnpm run cliTomas Vik (0719be26) at 17 Mar 13:17
chore: remove await from jest mocking
@phikai I see subcommand as an action and flag as something that changes the behaviour of an action (e.g. resolve vs --output json).
The precedent for subcommands as actions:
glab opentofu state lock/unlockglab runnercontroller token revoke/rotateglab project members add/removeglab ci cancel job/pipelineI can refactor this to use note --resolve/unresolve if the subcommand seems like a ux blocker.
I also planned to create glab mr note create for creating (diff) discussions.
/cc @timofurrer
Tomas Vik (cc62db3a) at 17 Mar 10:41
Tomas Vik (0e3e9d2c) at 17 Mar 10:41
Merge branch 'Copy-rg-from-ls' into 'main'
... and 1 more commit
Updates the extension build to include the rg binary from the language server's npm package alongside the other language server assets.
The language server now ships rg in its out/ directory. The extension build's glob patterns in scripts/utils/common_jobs.mjs are updated to copy rg?(.exe) from node_modules/@gitlab-org/gitlab-lsp/out/ to dist-desktop/assets/language-server/ so it is available at runtime.
Depends on: gitlab-org/editor-extensions/gitlab-lsp!3042
gitlab-org/editor-extensions/gitlab-lsp#1764
Verified rg is present in dist-desktop/assets/language-server/ after the extension build
If src/browser or src/common has been modified, please consider interoperability with the Web IDE. See Running the Extension in WebIDE.
Consider an end-to-end test for significant new features that aren't covered by integration tests.
fix: Bug fix fixes - a user-facing issue in production - included in changelogfeature: New feature - a user-facing change which adds functionality - included in changelogBREAKING CHANGE: (fix or feature that would cause existing functionality to change) - should bump major version, mentioned in the changelog