Tomas Vik activity https://gitlab.com/viktomas 2026-03-17T20:20:58Z tag:gitlab.com,2026-03-17:5214404816 Tomas Vik pushed to project branch tv/2026-03/first-class-glab at GitLab.org / editor-extensions / GitLab Language Server 2026-03-17T19:12:16Z viktomas Tomas Vik [email protected]

Tomas Vik (69784c48) at 17 Mar 19:12

feat(cli): adapt Duo CLI behavior for glab distribution

... and 21 more commits

tag:gitlab.com,2026-03-17:5213089306 Tomas Vik commented on merge request !2968 at GitLab.org / cli 2026-03-17T14:03:42Z viktomas Tomas Vik [email protected]

I think this is tough because we've got two nouns in these commands (mr, note) and each of the nouns requires an object, but the action is really on the second noun. 🤔

@phikai yeah, note and list are both nouns and verbs, right? 😅 I get the point. I'm slightly concerned about where would we end up with the flag complexity if we implement the full Draft: feat(mr): glab mr note supports all comm... (!2932) on glab mr note, there would be a large amount of flags that would be mutually exclusive and the subcommand namespacing can IMO keep the complexity in check 🤔

tag:gitlab.com,2026-03-17:5213074449 Tomas Vik commented on merge request !2968 at GitLab.org / cli 2026-03-17T14:00:55Z viktomas Tomas Vik [email protected]

Similarly... glab mr note list - how is that different than glab mr view --comments?

!2965 (merged)

@phikai TL;DR the output is identical but without the MR metadata being attached to it, there is extra filtering on type, state and file. When my agent works with comments, it doesn't need the MR metadata most of the time.

tag:gitlab.com,2026-03-17:5212959558 Tomas Vik deleted project branch renovate/commitlint-format-20.x at gitlab-renovate-forks / cli 2026-03-17T13:38:31Z viktomas Tomas Vik [email protected]

Tomas Vik (28d6a89f) at 17 Mar 13:38

tag:gitlab.com,2026-03-17:5212958522 Tomas Vik accepted merge request !2993: chore(deps): update dependency @commitlint/format to ^20.5.0 at GitLab.org / cli 2026-03-17T13:38:19Z viktomas Tomas Vik [email protected]

This MR contains the following updates:

Package Type Update Change
@commitlint/format (source) dependencies minor ^20.4.4 -> ^20.5.0

⚠️ Warning

Some dependencies could not be looked up. Check the warning logs for more information.

MR created with the help of gitlab-org/frontend/renovate-gitlab-bot


Release Notes

conventional-changelog/commitlint (@​commitlint/format)

v20.5.0

Compare Source

Note: Version bump only for package @​commitlint/format

20.4.4 (2026-03-12)

Note: Version bump only for package @​commitlint/format

20.4.3 (2026-03-03)

Note: Version bump only for package @​commitlint/format


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this MR and you won't be reminded about this update again.


  • If you want to rebase/retry this MR, check this box

This MR has been generated by Renovate Bot.

tag:gitlab.com,2026-03-17:5212958436 Tomas Vik pushed to project branch main at GitLab.org / cli 2026-03-17T13:38:18Z viktomas Tomas Vik [email protected]

Tomas Vik (1e68ce39) at 17 Mar 13:38

Merge branch 'renovate/commitlint-format-20.x' into 'main'

... and 1 more commit

tag:gitlab.com,2026-03-17:5212935573 Tomas Vik deleted project branch afontaine/cli-binary-configurable-targets at GitLab.org / editor-extensions / GitLab Language Server 2026-03-17T13:33:48Z viktomas Tomas Vik [email protected]

Tomas Vik (50537de3) at 17 Mar 13:33

tag:gitlab.com,2026-03-17:5212931058 Tomas Vik accepted merge request !3062: chore(cli): allow SUPPORTED_TARGETS to be set externally at GitLab.org / editor-extensions / GitLab Language Server 2026-03-17T13:32:53Z viktomas Tomas Vik [email protected]

Summary

Default the SUPPORTED_TARGETS variable in compile_executables.sh using shell parameter expansion (${VAR:-default}) so callers can override it by setting the variable in the environment before invoking the script.

Motivation

This is particularly useful when building the package with Nix, where only the target matching the host platform is needed and cross-compilation targets are unnecessary. The nixpkgs expression currently works around this with a sed patch (source); this change makes that workaround unnecessary.

Changes

  • packages/cli/scripts/compile_executables.sh: wrap the default target list with ${SUPPORTED_TARGETS:-...} so the variable can be overridden externally.
tag:gitlab.com,2026-03-17:5212930536 Tomas Vik pushed to project branch main at GitLab.org / editor-extensions / GitLab Language Server 2026-03-17T13:32:48Z viktomas Tomas Vik [email protected]

Tomas Vik (774fc8c4) at 17 Mar 13:32

Merge branch 'afontaine/cli-binary-configurable-targets' into 'main'

... and 1 more commit

tag:gitlab.com,2026-03-17:5212883794 Tomas Vik approved merge request !2993: chore(deps): update dependency @commitlint/format to ^20.5.0 at GitLab.org / cli 2026-03-17T13:24:00Z viktomas Tomas Vik [email protected]

This MR contains the following updates:

Package Type Update Change
@commitlint/format (source) dependencies minor ^20.4.4 -> ^20.5.0

⚠️ Warning

Some dependencies could not be looked up. Check the warning logs for more information.

MR created with the help of gitlab-org/frontend/renovate-gitlab-bot


Release Notes

conventional-changelog/commitlint (@​commitlint/format)

v20.5.0

Compare Source

Note: Version bump only for package @​commitlint/format

20.4.4 (2026-03-12)

Note: Version bump only for package @​commitlint/format

20.4.3 (2026-03-03)

Note: Version bump only for package @​commitlint/format


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this MR and you won't be reminded about this update again.


  • If you want to rebase/retry this MR, check this box

This MR has been generated by Renovate Bot.

tag:gitlab.com,2026-03-17:5212854976 Tomas Vik commented on merge request !3049 at GitLab.org / editor-extensions / GitLab Language Server 2026-03-17T13:18:37Z viktomas Tomas Vik [email protected]

Thanks @elwyn-gitlab, the MR LGMT 👍 I pushed a small test syntax tweak to save us a round trip 🙇 🚀

tag:gitlab.com,2026-03-17:5212851787 Tomas Vik approved merge request !3049: refactor(cli): extract prompt history management into PromptHistoryController at GitLab.org / editor-extensions / Git... 2026-03-17T13:17:58Z viktomas Tomas Vik [email protected]

Description

Extracts prompt history management out of TUIController into a dedicated PromptHistoryController DI service.

TUIController was handling storage initialisation, history loading, and all 7 prompt history callbacks inline. This is inconsistent with our newer features with dedicated handlers and leaves tui controller doing more than it should.

Also moved the call to load the prompt history higher in the init flow - pressing "up" or "ctrl+r" is often one of my earliest interactions and currently it feels unresponsive because we do all network initialisation before the fast filesystem history loading.

Issue #2139

How has this been tested?

  • checkout this branch
  • mise install && npm install
  • npm run cli
  • confirm prompt history works (up/down arrows, ctrl+r, search etc)

What CHANGELOG entry will this MR create?

  • other non-user-facing changes
tag:gitlab.com,2026-03-17:5212850729 Tomas Vik pushed to project branch extract-prompt-history-controller at GitLab.org / editor-extensions / GitLab Language Server 2026-03-17T13:17:45Z viktomas Tomas Vik [email protected]

Tomas Vik (0719be26) at 17 Mar 13:17

chore: remove await from jest mocking

tag:gitlab.com,2026-03-17:5212796242 Tomas Vik commented on merge request !2968 at GitLab.org / cli 2026-03-17T13:06:54Z viktomas Tomas Vik [email protected]

@phikai I see subcommand as an action and flag as something that changes the behaviour of an action (e.g. resolve vs --output json).

The precedent for subcommands as actions:

  • glab opentofu state lock/unlock
  • glab runnercontroller token revoke/rotate
  • glab project members add/remove
  • glab ci cancel job/pipeline

I can refactor this to use note --resolve/unresolve if the subcommand seems like a ux blocker.

I also planned to create glab mr note create for creating (diff) discussions.

/cc @timofurrer

tag:gitlab.com,2026-03-17:5212141053 Tomas Vik deleted project branch Copy-rg-from-ls at GitLab.org / gitlab-vscode-extension 2026-03-17T10:41:28Z viktomas Tomas Vik [email protected]

Tomas Vik (cc62db3a) at 17 Mar 10:41

tag:gitlab.com,2026-03-17:5212140691 Tomas Vik pushed to project branch main at GitLab.org / gitlab-vscode-extension 2026-03-17T10:41:23Z viktomas Tomas Vik [email protected]

Tomas Vik (0e3e9d2c) at 17 Mar 10:41

Merge branch 'Copy-rg-from-ls' into 'main'

... and 1 more commit

tag:gitlab.com,2026-03-17:5212140652 Tomas Vik accepted merge request !3127: chore: Copy `ripgrep` from LS build at GitLab.org / gitlab-vscode-extension 2026-03-17T10:41:23Z viktomas Tomas Vik [email protected]

Description

Updates the extension build to include the rg binary from the language server's npm package alongside the other language server assets.

The language server now ships rg in its out/ directory. The extension build's glob patterns in scripts/utils/common_jobs.mjs are updated to copy rg?(.exe) from node_modules/@gitlab-org/gitlab-lsp/out/ to dist-desktop/assets/language-server/ so it is available at runtime.

Depends on: gitlab-org/editor-extensions/gitlab-lsp!3042

gitlab-org/editor-extensions/gitlab-lsp#1764

How has this been tested?

  • Verified rg is present in dist-desktop/assets/language-server/ after the extension build

  • If src/browser or src/common has been modified, please consider interoperability with the Web IDE. See Running the Extension in WebIDE.

  • Consider an end-to-end test for significant new features that aren't covered by integration tests.

What CHANGELOG entry will this MR create?

  • fix: Bug fix fixes - a user-facing issue in production - included in changelog
  • feature: New feature - a user-facing change which adds functionality - included in changelog
  • BREAKING CHANGE: (fix or feature that would cause existing functionality to change) - should bump major version, mentioned in the changelog
  • None - other non-user-facing changes