Updated README with a note about this, thanks!

Will Meek (97e99ce8) at 13 Mar 16:09

Done thanks

Thanks for the feedback!

I'd used the investigation notes from https://gitlab.com/gitlab-org/quality/quality-engineering/team-tasks/-/work_items/4270#note_3116297428 which GitLab suggested to use goimports for consistency.

On the wider question, I'd had a discussion with Nadya and for the meantime we want to focus on a distinct project (this modular-feature-testing). However I do take the point that we can end up with 2 competing golangci.yaml files if a project consumes go-service-template. We have a call next week and one of the points will be how we can relate both projects.

Set pipefail, good call

Thanks!

I was looking at examples where it was set, but it seems a default value? Removed.

Fantastic work Tiffany, thank you!

Couple of minor things but you could probably take it out of draft get it ready for merging.

nitpick: Looks like a merge artifact

Should we have a section for mise?

I'm fairly new to go and getting used to the tools around it, but I think this was deprecated from 1.17 (If we're initially targeting 1.22 - we might want that as a variable or dependeabot updatable value in a next iteration) - https://go.dev/doc/go-get-install-deprecation

From what I can gather the alternate command might be

- go install github.com/boumenot/gocover-cobertura@latest

Will Meek (72125e8c) at 13 Mar 11:36

@treagitlab Tiffany, this MR is for linting, if you'd like to have a look, feedback welcome! Thanks

Same here, token rotation investigation and reviews (I kept getting bitten by pipeline issues / merge train failures)

@chloeliu @jay_mccure Chloe, Jay

Feedback is welcome on the proposal for Go linting in this MR. Thanks!

Seeing similar in review job https://gitlab.com/gitlab-org/quality/quality-engineering/modular-feature-testing/-/jobs/13470438624

        - Response body: {"error":"insufficient_scope","error_description":"The request requires higher privileges than provided by the access token.","scope":"read_user ai_features api read_api"}

Will Meek (c4b06c29) at 12 Mar 14:11