Merge Info

Issues

Resolves

• #294

Related

Merging

Target Branches

• mullvad-browser - !fixups to mullvad-browser-specific commits, new features, security backports
• base-browser and tor-browser - !fixups to base-browser-specific commits or new features to be shared with tor-browser
  • ⚠️ IMPORTANT: Please list the base-browser-specific commits which need to be cherry-picked to the base-browser and tor-browser branches here

Target Channels

• Alpha: rapid release, 16.0
• Stable: esr140-15.0

Backporting

Timeline

• No Backport (preferred): patchset for the next major stable
• Immediate: patchset needed as soon as possible (fixes CVEs, 0-days, etc)
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport

(Optional) Justification

• Security update: patchset contains a security fix (be sure to select the correct item in Timeline)
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Localization: typos and other localization changes that should be also in the release branch
• Other: please explain

Upstream

• Patchset is a candidate for uplift to Firefox
• Patchset is a backport from Firefox
  • Bugzilla link:
  • Upstream commit:

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • frontend (implementation) : henry
  • localization : henry, pierov
  • nightly builds : boklm
  • updater : pierov

Change Description

Prompt the user before restarting the browser after pressing Restart to apply an update

How Tested

(async () => {

const { AppMenuNotifications } = await ChromeUtils.importESModule( "resource://gre/modules/AppMenuNotifications.sys.mjs");

const { UpdateListener } = await ChromeUtils.importESModule(

"resource://gre/modules/UpdateListener.sys.mjs" );

AppMenuNotifications.showNotification(

"update-restart",

{ callback() { UpdateListener.requestRestart(); },

dismiss: true, }, null, { name: "test-update" } );

Services.wm.getMostRecentWindow("navigator:browser").PanelUI.show(); })();

any1here (8920a89a) at 19 Mar 16:50

I understood what you meant in the first comment 👍

@henry Would you mind if I work on this?

Could the Bugzilla issue you are referring to be the wrong one, and did you instead mean https://bugzilla.mozilla.org/show_bug.cgi?id=2005799, which was introduced in 148.0‑beta11?

Is removing the related parts from the build still a must, or is using the new toggles that block the features from being shown and run a possibility instead? Using

lockPref("browser.ai.control.default", "blocked");

lockPref("browser.ai.control.linkPreviewKeyPoints", "blocked");

lockPref("browser.ai.control.pdfjsAltText", "blocked");

lockPref("browser.ai.control.sidebarChatbot", "blocked");

lockPref("browser.ai.control.smartTabGroups", "blocked");

lockPref("browser.ai.control.translations", "blocked");

removes the ability for the related code to be run/shown, and setting

lockPref("browser.preferences.aiControls", false);

also removes the AI controls in about:preferences.