Sorry to be a pain, I was late to the main design doc review and just had a few minor points I wanted to suggest to see how the team feels about them, feel free to suggest dropping them, they'd have been comment suggestions if I was more timely

@pierov @ma1 @brizental @clairehurst @boklm @henry @jwilde

A few minor suggestions after reading the updated design doc

• are Bookmarks considered part of Browsing History or worth mentioning seperatly

• My thoughts on LLMs are perhaps not surprising but I thought I'd offer them here to see if the wider team wanted to include reasoning about them here or not

• emphasizing that detection of Tor or Tor Browser can alone be some folks' threat model, as a starting point for very simple and penetrable with knowledge, but sometimes sufficient clocking mitigations like the android icon picked (as seen in other apps)

• also I had a minor pedant moment reading 2.1.3 Disk Avoidance:

  • By default, the browser and any built-in extensions MUST NOT write any information that is derived from or that reveals browsing activity to the disk unencrypted
  • we do check for extension updates so that might leak recent run times. I didn't actually add this cus it's incredibly minor but also wanted to see if anyone felt stronger about it

Dan Ballard (97ae621f) at 19 Mar 00:12

... and 60 more commits

aaan right, android has process management in TorAndroidIntegration.java. Ok cool. That's a lot better, so then this probably isn't related then.

oh could you add detail about this in the README.md? just so it's not lore that would require reading our scripts fpr new folks, thanks!

Ok looking good, builds and runs for me, just a few unresolved threads. Closed the ones that looked like the comments were in agreement but there's a few still needing a decision. I think one of mine just needs an answer and can be resolved, and few others need a response, and then it should be good to go!

android builds and runs for me now 👍

so looking pretty good, no extra issues from me aside from some spin off issues. Just waiting on fixes so android compiles

using the shared https://tb-build-03.torproject.org/~pierov/out/application-services/application-services-149.0-2026-02-23-95ed3a.tar.zst to build I got this too. Will wait till it's incorporated into the patchset to test tomorrow

so we might be able to remove SupportUtils.getTorWhatsNewUrl() from it's commit? got approval from me if you want to make a follow up issue

and SavedLoginsListView.kt is just being remoevd in 4fad711f

If it is turning up somewhere else our audits or testing should catch it

something also changed mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/middleware/MenuNavigationMiddleware.kt and dropped the ReleaseNotes path that we have changed to SupportUtils.getTorWhatsNewUrl()

looks like

• e108d0fb: Bug 1972333 - Part 6: Remove ReleaseNotes menu action r=android-reviewers,gl
• Differential Revision: https://phabricator.services.mozilla.com/D279783

so i guess that's fine

looking at the commit more it's a spin off, to do the work

#44777

so this work is 👍

2e8b187a fixup! [android] Rename as Tor Browser

--    imageRes = R.drawable.ic_firefox,
+-    imageRes = R.drawable.nova_onboarding_tou,
 +    imageRes = R.mipmap.ic_launcher_foreground,

we change firefox image assets to tor as part of rename, and else where we remove assets we wont use and change their code reference to something left behind.

Since this is TermsOfServiceOnboardingPageRedesign.kt and we dont show onboarding, this raises a question: we could just drop the rename of asset from a firefox to tor one here, it should be fine. but also upstream change from ic_firefox to nova_onboarding_tou which we could leave or not, but checking,

./mobile/android/fenix/app/src/main/res/drawable/nova_onboarding_tou_2.xml
./mobile/android/fenix/app/src/main/res/drawable/nova_onboarding_tou.xml

are both still in tree and if we're not using, we should delete for size savings. And since we're not showing this page, if this is the only place the asset it used, I'd vote we keep the rename and add deleting the assets. @clairehurst thoughts as you maintain most the asset deletion commit

Linux built and runs 👍

few i looked at a bit more, result of me slowly getting better at reading range diffs and needing to stare a bit longer to convince myself it's all good, this just me talking out loud to myself.

• BB 42716: Disable unwanted about: pages

  • 148: 4cb2ef62
  • 149: boklm/tor-browser@62869f5c
  • looks simple, just changing deletion of moz changed lines

• TB 40002: [android] Ensure system download manager is not used

  • 148: e41e8a4d
  • 149: boklm/tor-browser@ca1f074a
  • looks like a lot of trivial lines added to blocks we commented out, and then restructuring of whole tests in blocks we're dropping

• [android] Override settings

• 148: 0bc96d47

• 149: boklm/tor-browser@f5f52533

• moz just compressed per channel settings to one

• TB 34403 [android]: Disable Normal mode by default.

  • 148: c23d6ad2
  • 149: boklm/tor-browser@f20cceb4
  • oh wow moz deleted mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt and mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayBanner.kt
  • tracked above and in #44774 (closed)

• TB 40016 [android]: Don't install WebCompat webext.

• same as above

saw a bunch of this in 148, seems an ongoing process

services/settings/dumps/main/newtab-wallpapers-v2.json I am guessing doesn't need deleting because it won't be included in builds this way?

cool, #44775