feat(forms): support binding null to number input by mmalerba · Pull Request #66917 · angular/angular

mmalerba · 2026-02-05T00:31:17Z

Supports binding null to a <input type=number>.

Treats a model value of null the same as a model value of NaN
When the user clears the input, reports null rather than NaN
When the user types an invalid number, model does not update, raises
an error via the parse errors mechanism

packages/forms/signals/test/web/number_input.spec.ts

packages/forms/signals/src/directive/control_native.ts

leonsenft · 2026-02-10T17:55:46Z

packages/forms/signals/src/directive/control_native.ts

 ): () => void {
  let updateMode = false;
  const input = parent.nativeFormElement;
+  // TODO: (perf) ok to always create this?


What's the alternative? Could we only create this if we know it's a numeric input?

yeah we could look at the input type and only do it for types that have parsing. (e.g. type=text wouldn't need it), wanted to see if people thought that's worth it or not

Is there a compelling reason not to?

I guess it means this call site needs to encode some of the same work done inside getNativeControlValue() to know whether it should handle parse errors.

yeah, it felt like duplicating logic that checks the input type, that we already have elsewhere. then if we ever needed to add parsing to another type we'd have to remember to opt it in here in addition to adding the logic for it

packages/forms/signals/src/directive/native.ts

goldens/public-api/forms/signals/index.api.md

packages/forms/signals/src/directive/native.ts

Changes `parsedErrors` to a `linkedSignal` based on the model value. This ensures that the parse errors are reset if the model changes from outside the control.

Integrates native inputs with the new parseErrors API so that they can report parse errors when the user types an un-parsable value (e.g. "42e" in a number field). When a user types an un-parsable value, the model does not update. It retains its previous value and a parse error is added for the control that received the un-parsable value.

Supports binding `null` to a `<input type=number>`. - Binding in `null` clears the input - Binding in `NaN` also clears the input - When the user clears the input, the model is set to `null` - The model is _never_ set to `NaN` based on user interaction. It is either set to `null` if the user cleared the input, or is unchanged and a parse error added if the user entered an invalid number like "42e"

native controls and custom controls (via transformedValue) use similar parsing logic but it needs to be hooked up differently. This commit extracts the common bits into a shared piece.

leonsenft

reviewed-for: public-api

ngbot · 2026-02-12T19:14:37Z

I see that you just added the action: merge label, but the following checks are still failing:
     status "google-internal-tests" is failing
     missing required labels: target: *
     3 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

mmalerba · 2026-02-12T19:15:26Z

caretaker: passing tgp

mattrbeck · 2026-02-13T20:11:09Z

This PR was merged into the repository. The changes were merged into the following branches:

main: a6a0347

Integrates native inputs with the new parseErrors API so that they can report parse errors when the user types an un-parsable value (e.g. "42e" in a number field). When a user types an un-parsable value, the model does not update. It retains its previous value and a parse error is added for the control that received the un-parsable value. PR Close #66917

Supports binding `null` to a `<input type=number>`. - Binding in `null` clears the input - Binding in `NaN` also clears the input - When the user clears the input, the model is set to `null` - The model is _never_ set to `NaN` based on user interaction. It is either set to `null` if the user cleared the input, or is unchanged and a parse error added if the user entered an invalid number like "42e" PR Close #66917

native controls and custom controls (via transformedValue) use similar parsing logic but it needs to be hooked up differently. This commit extracts the common bits into a shared piece. PR Close #66917

angular-automatic-lock-bot · 2026-03-16T00:21:44Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

angular-robot bot added detected: feature PR contains a feature commit area: forms labels Feb 5, 2026

ngbot bot added this to the Backlog milestone Feb 5, 2026

mmalerba changed the title ~~fix(forms): simplify design of parse errors~~ feat(forms): support binding null to number input Feb 5, 2026

mmalerba added the forms: signals label Feb 5, 2026

github-project-automation bot added this to Experimental Signal Forms Feb 5, 2026

mmalerba force-pushed the sf/number branch 4 times, most recently from 66e5dea to 714ff23 Compare February 9, 2026 22:21

mmalerba requested review from alxhub and leonsenft February 9, 2026 22:22

mmalerba marked this pull request as ready for review February 9, 2026 22:22

mmalerba requested a review from kirjs February 9, 2026 22:22

JeanMeche reviewed Feb 9, 2026

View reviewed changes

packages/forms/signals/test/web/number_input.spec.ts Outdated Show resolved Hide resolved

JeanMeche mentioned this pull request Feb 10, 2026

Signal Forms Optional Fields - Nullability #65454

Closed

leonsenft requested changes Feb 10, 2026

View reviewed changes

mmalerba requested review from JeanMeche and leonsenft February 10, 2026 22:15

leonsenft requested changes Feb 10, 2026

View reviewed changes

goldens/public-api/forms/signals/index.api.md Show resolved Hide resolved

packages/forms/signals/src/directive/native.ts Outdated Show resolved Hide resolved

mmalerba added 7 commits February 10, 2026 17:38

fix(forms): clear parse errors when model updates

72a1a9e

Changes `parsedErrors` to a `linkedSignal` based on the model value. This ensures that the parse errors are reset if the model changes from outside the control.

fixup! feat(forms): support binding null to number input

1f91072

fixup! feat(forms): support binding null to number input

75d1b58

refactor(forms): extract common parser logic

338645a

native controls and custom controls (via transformedValue) use similar parsing logic but it needs to be hooked up differently. This commit extracts the common bits into a shared piece.

fixup! refactor(forms): extract common parser logic

ad38f8a

mmalerba force-pushed the sf/number branch from 07d9ad9 to ad38f8a Compare February 11, 2026 01:38

mmalerba requested a review from leonsenft February 11, 2026 01:41

leonsenft approved these changes Feb 11, 2026

View reviewed changes

mmalerba added the action: merge The PR is ready for merge by the caretaker label Feb 12, 2026

mmalerba added target: minor This PR is targeted for the next minor release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Feb 12, 2026

JeanMeche removed request for JeanMeche, alxhub and kirjs February 13, 2026 01:10

mmalerba removed the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Feb 13, 2026

mattrbeck closed this in 27397b3 Feb 13, 2026

github-project-automation bot moved this to Done in Experimental Signal Forms Feb 13, 2026

angular-bootstrap mentioned this pull request Feb 28, 2026

fix(forms): treat cleared date input as empty value #67363

Closed

14 tasks

michael-small mentioned this pull request Mar 3, 2026

Adds angular-developer agent skill #67398

Open

14 tasks

angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 16, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(forms): support binding null to number input#66917

feat(forms): support binding null to number input#66917
mmalerba wants to merge 7 commits intoangular:mainfrom
mmalerba:sf/number

mmalerba commented Feb 5, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

leonsenft Feb 10, 2026

Uh oh!

mmalerba Feb 10, 2026

Uh oh!

leonsenft Feb 10, 2026 •

edited

Loading

Uh oh!

mmalerba Feb 11, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

leonsenft left a comment

Uh oh!

ngbot bot commented Feb 12, 2026

Uh oh!

mmalerba commented Feb 12, 2026 •

edited

Loading

Uh oh!

mattrbeck commented Feb 13, 2026

Uh oh!

angular-automatic-lock-bot bot commented Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mmalerba commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

leonsenft Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

mmalerba Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

leonsenft Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mmalerba Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

leonsenft left a comment

Choose a reason for hiding this comment

Uh oh!

ngbot bot commented Feb 12, 2026

Uh oh!

mmalerba commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mattrbeck commented Feb 13, 2026

Uh oh!

angular-automatic-lock-bot bot commented Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mmalerba commented Feb 5, 2026 •

edited

Loading

leonsenft Feb 10, 2026 •

edited

Loading

mmalerba commented Feb 12, 2026 •

edited

Loading