Skip to content

fix(aria/menu): itemSelected not emitted when menu is attached to a trigger#32880

Merged
crisbeto merged 1 commit intoangular:mainfrom
crisbeto:32865/aria-menu-select-item
Mar 4, 2026
Merged

fix(aria/menu): itemSelected not emitted when menu is attached to a trigger#32880
crisbeto merged 1 commit intoangular:mainfrom
crisbeto:32865/aria-menu-select-item

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 4, 2026

The logic that dispatches itemSelected wasn't accounting for the case where the menu root is a trigger.

Fixes #32865.

…rigger

The logic that dispatches `itemSelected` wasn't accounting for the case where the menu root is a trigger.

Fixes angular#32865.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Mar 4, 2026
@pullapprove pullapprove bot requested review from adolgachev and tjshiu March 4, 2026 12:00
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 4, 2026
@crisbeto crisbeto merged commit e69549c into angular:main Mar 4, 2026
26 of 28 checks passed
@crisbeto
Copy link
Member Author

crisbeto commented Mar 4, 2026

This PR was merged into the repository. The changes were merged into the following branches:

crisbeto added a commit that referenced this pull request Mar 4, 2026
…rigger (#32880)

The logic that dispatches `itemSelected` wasn't accounting for the case where the menu root is a trigger.

Fixes #32865.

(cherry picked from commit e69549c)
jermowery pushed a commit to jermowery/components that referenced this pull request Mar 13, 2026
…rigger (angular#32880)

The logic that dispatches `itemSelected` wasn't accounting for the case where the menu root is a trigger.

Fixes angular#32865.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(aria/menu): itemSelected event is not triggered when selecting an ngMenuItem

2 participants