build: Update doublestar to a version that works with the latest Gazelle#2480
Merged
aignas merged 5 commits intobazel-contrib:mainfrom Mar 7, 2025
Merged
build: Update doublestar to a version that works with the latest Gazelle#2480aignas merged 5 commits intobazel-contrib:mainfrom
aignas merged 5 commits intobazel-contrib:mainfrom
Conversation
Collaborator
|
I ran this locally and didn't see any issues 🎉. The previous comments still need to be addressed though. |
dougthor42
reviewed
Dec 19, 2024
Collaborator
dougthor42
left a comment
dougthor42
left a comment
There was a problem hiding this comment.
Just a whitespace nit but otherwise LGTM. When that's fixed I'll give the 👍
Collaborator
|
@aignas @rickeylev I'm not yet super familiar with the CI pipeline, so I'm not sure if that buildkite failure is a blocker or not, or if it's just a flake. |
Contributor
Author
|
I think this was just a flaky run: could not download Bazel: failed to download bazel: failed to download bazel:. If someone with BuildKite permissions is around, there's a "retry" button, which will allow that one build to be retried. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.