chore: Remove *_build_test targets from sphinx_docs (#2645)#2650
Merged
aignas merged 2 commits intobazel-contrib:mainfrom Mar 6, 2025
Merged
chore: Remove *_build_test targets from sphinx_docs (#2645)#2650aignas merged 2 commits intobazel-contrib:mainfrom
aignas merged 2 commits intobazel-contrib:mainfrom
Conversation
Remove implicit build_tests from sphinx_docs targets. Instead, users can decide whether or not to add build_tests for docs. This also keeps sphinx_docs builds out of `bazel test //...`, which may not be desirable. Add build_tests to cover in-tree sphinx_docs targets. Rename the existing build_test for //sphinxdocs/tests/sphinx_docs:docs to match the new targets. Also, tag the sphinx_docs *.run and *.serve targets as "manual" so they are excluded from wildcards. These are only needed for interactive development.
rickeylev
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove implicit
build_tests fromsphinx_docstargets. Instead, users can decide whether or not to addbuild_testsfor docs. This also keepssphinx_docsbuilds out ofbazel test //..., which may not be desirable.Add
build_tests to cover in-treesphinx_docstargets. Rename the existingbuild_testfor//sphinxdocs/tests/sphinx_docs:docsto match the new targets.Also, tag the
sphinx_docs*.runand*.servetargets as"manual"so they are excluded from wildcards. These are only needed for interactive development.